inpcb: Remove checks for NULL credential references
ClosedPublic
Actions

Authored by markj on Oct 17 2022, 8:39 PM.

Details

Reviewers

Group Reviewers

Commits

rG3e27fcf05793: inpcb: Remove NULL checks of credential references
rGac1750dd143e: inpcb: Remove NULL checks of credential references

Summary

Some auditing of the code shows that "cred" is never non-NULL in these
functions, either because all callers pass a non-NULL reference or
because they unconditionally dereference "cred". So, let's simplify the
code a bit and remove NULL checks. No functional change intended.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 47862
Build 44749: arc lint + arc unit

Event Timeline

markj created this revision.Oct 17 2022, 8:39 PM

Herald added subscribers: glebius, melifaro, ae, imp. · View Herald TranscriptOct 17 2022, 8:39 PM

markj requested review of this revision.Oct 17 2022, 8:39 PM

Harbormaster completed remote builds in B47862: Diff 111872.Oct 17 2022, 8:39 PM

markj added a child revision: D37026: inpcb: Return an error when binding to an LB group if it is too large.Oct 17 2022, 8:39 PM

glebius accepted this revision.Oct 18 2022, 4:27 AM

glebius added inline comments.

sys/netinet/in_pcb.c
1171	May be add documenting MPASS(cred) here and in other functions?

This revision is now accepted and ready to land.Oct 18 2022, 4:27 AM

markj added inline comments.Oct 18 2022, 1:42 PM

sys/netinet/in_pcb.c
1171	If you really prefer it I will do it, but to me it's overkill. These functions are not providing general-purpose interfaces, so it's ok to make assumptions like this IMO.