Page MenuHomeFreeBSD
Differential D36943

refcount.9: Update refcount_acquire(9) description after a67d540832b8
ClosedPublic
Actions

Authored by khng on Oct 12 2022, 6:58 AM.
Tags
None
Referenced Files
F97595124: D36943.diff
Mon, Sep 30, 6:21 AM
F97476843: D36943.diff
Sun, Sep 29, 2:32 PM
Unknown Object (File)
Sun, Sep 29, 4:15 AM
Unknown Object (File)
Sat, Sep 28, 4:25 PM
Unknown Object (File)
Fri, Sep 27, 4:09 PM
Unknown Object (File)
Fri, Sep 27, 1:32 PM
Unknown Object (File)
Fri, Sep 27, 3:22 AM
Unknown Object (File)
Fri, Sep 27, 2:48 AM
View All 52 Files
Subscribers
imp

Details

Reviewers
markj
kib
Commits
rGf187bd281e52: refcount.9: Update refcount_acquire(9) description after a67d540832b8
rG87fa64c569c5: refcount.9: Update refcount_acquire(9) description after a67d540832b8
Summary

MFC after: 3 days
Sponsored by: Juniper Networks, Inc.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 47800
Build 44687: arc lint + arc unit

Event Timeline

khng created this revision.Oct 12 2022, 6:58 AM
Herald added a subscriber: imp. · View Herald TranscriptOct 12 2022, 6:58 AM
khng requested review of this revision.Oct 12 2022, 6:58 AM
Harbormaster completed remote builds in B47785: Diff 111678.Oct 12 2022, 6:58 AM
kib added inline comments.Oct 12 2022, 10:23 AM
share/man/man9/refcount.9
96

I would say 'value' and not 'snapshot'.

markj added a comment.Oct 12 2022, 3:13 PM

BTW, a number of refcount functions are not documented here: acquiren, releasen, acquire_if_gt, acquire_if_not_gt.

share/man/man9/refcount.9
96

+1

khng added a comment.Oct 12 2022, 3:17 PM
In D36943#839227, @markj wrote:

BTW, a number of refcount functions are not documented here: acquiren, releasen, acquire_if_gt, acquire_if_not_gt.

Yes, I realized that. I will address them in a separate diff.

khng updated this revision to Diff 111720.Oct 12 2022, 5:15 PM
  • Remove "the snapshot of"
  • grammar fix
Harbormaster completed remote builds in B47800: Diff 111720.Oct 12 2022, 5:15 PM
markj added inline comments.Oct 12 2022, 5:17 PM
share/man/man9/refcount.9
100

This sentence ("For example, ...") is logically connected to the one that starts with "The caller is responsible...", so the new sentence should come before both or after both.

khng updated this revision to Diff 111721.Oct 12 2022, 5:30 PM

Move the return value description above usage details.

Harbormaster completed remote builds in B47801: Diff 111721.Oct 12 2022, 5:30 PM
markj accepted this revision.Oct 12 2022, 5:33 PM
This revision is now accepted and ready to land.Oct 12 2022, 5:33 PM
Closed by commit rG87fa64c569c5: refcount.9: Update refcount_acquire(9) description after a67d540832b8 (authored by khng). · Explain WhyOct 12 2022, 5:49 PM
This revision was automatically updated to reflect the committed changes.
khng added a commit: rG87fa64c569c5: refcount.9: Update refcount_acquire(9) description after a67d540832b8.
khng added a commit: rGf187bd281e52: refcount.9: Update refcount_acquire(9) description after a67d540832b8.Oct 21 2022, 6:14 AM

Revision Contents
Changeset List

PathSize
share/
man/
man9/
5 lines

Diff 111720

View Options

share/man/man9/refcount.9

Loading...