Page MenuHomeFreeBSD

release: link from /boot/msdos to efi
ClosedPublic

Authored by imp on Oct 11 2022, 7:08 PM.
Tags
None
Referenced Files
F102013567: D36941.diff
Wed, Nov 6, 1:29 PM
Unknown Object (File)
Oct 3 2024, 7:35 PM
Unknown Object (File)
Oct 1 2024, 10:24 PM
Unknown Object (File)
Sep 28 2024, 4:46 AM
Unknown Object (File)
Sep 15 2024, 5:19 AM
Unknown Object (File)
Sep 14 2024, 7:23 PM
Unknown Object (File)
Sep 5 2024, 5:27 AM
Unknown Object (File)
Sep 1 2024, 6:47 AM

Details

Summary

We need to do a relative link to efi instead of an absolute link into
the build tree.

Sponsored by: Netflix

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 47782
Build 44669: arc lint + arc unit

Event Timeline

imp requested review of this revision.Oct 11 2022, 7:08 PM
This revision is now accepted and ready to land.Oct 11 2022, 7:18 PM

Thank you for the quick fix.

In D36941#839018, @gjb wrote:

Thank you for the quick fix.

It helped that I saw the email and had two thoughts "hey, I know how to fix that" and "WTF was I on when I wrote the code not to know that"

This revision was automatically updated to reflect the committed changes.

Hmm. I'm actually wondering if it should be

ln -s /boot/efi ${DESTDIR}/boot/msdos

I think as-is, this will create a link from /efi. Or am I overthinking/overlooking something?

For:

ln -s efi ${DESTDIR}/boot/msdos

msdos points to efi in the same directory. No implicit / generation.

For:

ln -s /boot/efi ${DESTDIR}/boot/msdos

msdos points to /boot/efi .

Both ways reach the same file, as long as msdos is not moved to a different directory anyway.

For:

ln -s efi ${DESTDIR}/boot/msdos

msdos points to efi in the same directory. No implicit / generation.

For:

ln -s /boot/efi ${DESTDIR}/boot/msdos

msdos points to /boot/efi .

Both ways reach the same file, as long as msdos is not moved to a different directory anyway.

Thank you for the sanity check.