Page MenuHomeFreeBSD

systat: Fix a bunch of use after frees in fetch_ifstat().
ClosedPublic

Authored by jhb on Sep 29 2022, 10:34 PM.
Tags
None
Referenced Files
F97086592: D36823.diff
Fri, Sep 27, 5:43 PM
Unknown Object (File)
Fri, Sep 27, 3:39 AM
Unknown Object (File)
Wed, Sep 18, 10:08 PM
Unknown Object (File)
Mon, Sep 16, 1:47 PM
Unknown Object (File)
Sun, Sep 8, 7:46 AM
Unknown Object (File)
Thu, Sep 5, 4:45 PM
Unknown Object (File)
Thu, Sep 5, 7:54 AM
Unknown Object (File)
Mon, Sep 2, 3:01 PM
Subscribers

Details

Summary

I think this was probably just a typo. initifstat() continues around
a similar loop if the mib data fails to fetch, and fetch_ifstat() was
already using a FOREACH_SAFE loop here so expected to keep going.
Calling clearifstat() from the fetch routine also seems wrong, and the
sort_interface_list() call triggered by the existing needsort = 1 will
itself set needclear to trigger a future clearifstat().

Reported by: GCC 12 -Wuse-after-free

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable