Page MenuHomeFreeBSD

systat: Fix a bunch of use after frees in fetch_ifstat().
ClosedPublic

Authored by jhb on Sep 29 2022, 10:34 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Nov 14, 8:04 PM
Unknown Object (File)
Thu, Nov 14, 7:48 PM
Unknown Object (File)
Tue, Oct 29, 1:37 PM
Unknown Object (File)
Sun, Oct 20, 11:06 AM
Unknown Object (File)
Oct 3 2024, 11:18 AM
Unknown Object (File)
Oct 1 2024, 1:16 PM
Unknown Object (File)
Oct 1 2024, 10:13 AM
Unknown Object (File)
Sep 30 2024, 11:24 PM
Subscribers

Details

Summary

I think this was probably just a typo. initifstat() continues around
a similar loop if the mib data fails to fetch, and fetch_ifstat() was
already using a FOREACH_SAFE loop here so expected to keep going.
Calling clearifstat() from the fetch routine also seems wrong, and the
sort_interface_list() call triggered by the existing needsort = 1 will
itself set needclear to trigger a future clearifstat().

Reported by: GCC 12 -Wuse-after-free

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 47637
Build 44524: arc lint + arc unit