rescue: Link libzutil after libzfs.
ClosedPublic
Actions

Authored by jhb on Sep 29 2022, 10:25 PM.

Details

Reviewers

kib
emaste
imp

Commits

rG5e4854cbf8d8: rescue: Link libzutil after libzfs.

Summary

libzfs depends on symbols defined in libzutil. For static linking
ld.bfd is less forgiving than lld, so rescue was failing to link when
using ld.bfd due to unresolved symbols from libzutil used by libzfs.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 47625
Build 44512: arc lint + arc unit

Event Timeline

jhb created this revision.Sep 29 2022, 10:25 PM

Herald added a subscriber: imp. · View Herald TranscriptSep 29 2022, 10:25 PM

jhb requested review of this revision.Sep 29 2022, 10:25 PM

Harbormaster completed remote builds in B47625: Diff 111228.Sep 29 2022, 10:25 PM

I would argue that this is a bug in ld.lld.

This revision is now accepted and ready to land.Sep 30 2022, 12:27 AM

There is a note about this in ld.lld's man page under IMPLEMENTATION NOTES. There is a --warn-backrefs option documented there that we may want to investigate.

imp accepted this revision.Sep 30 2022, 3:07 AM

Closed by commit rG5e4854cbf8d8: rescue: Link libzutil after libzfs. (authored by jhb). · Explain WhyOct 3 2022, 11:13 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rG5e4854cbf8d8: rescue: Link libzutil after libzfs..