Differential D36664

vtblk: Make vtblk_request_execute return void.
ClosedPublic
Actions

Authored by cperciva on Sep 22 2022, 7:00 AM.

Tags

None

Referenced Files

	F97645025: D36664.id.diff
	Mon, Sep 30, 1:42 PM

	F97643472: D36664.id110838.diff
	Mon, Sep 30, 1:32 PM

	F97643304: D36664.id111898.diff
	Mon, Sep 30, 1:31 PM

	Unknown Object (File)
	Fri, Sep 27, 5:44 PM

	Unknown Object (File)
	Wed, Sep 25, 3:47 AM

	Unknown Object (File)
	Tue, Sep 24, 4:36 PM

	Unknown Object (File)
	Tue, Sep 24, 1:20 PM

	Unknown Object (File)
	Tue, Sep 24, 4:29 AM

View All 60 Files

Subscribers

Details

Reviewers

bryanv
imp

Commits

rG86f8f5ccb798: vtblk: Make vtblk_request_execute return void.

Summary

The error, if any, now gets stashed in the request structure. (Step 1
of reworking this driver to use busdma.)

No functional change intended.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 47485
Build 44372: arc lint + arc unit

Event Timeline

cperciva created this revision.Sep 22 2022, 7:00 AM

Herald added a subscriber: imp. · View Herald TranscriptSep 22 2022, 7:00 AM

cperciva requested review of this revision.Sep 22 2022, 7:00 AM

Harbormaster completed remote builds in B47485: Diff 110838.Sep 22 2022, 7:00 AM

cperciva added a child revision: D36665: vtblk: Requeue inside vtblk_request_execute.Sep 22 2022, 7:00 AM

cperciva mentioned this in D36667: vtblk: Use busdma.Sep 22 2022, 7:03 AM

bryanv accepted this revision.Oct 3 2022, 2:15 AM

This revision is now accepted and ready to land.Oct 3 2022, 2:15 AM

This is basically what CAM does and most of the SIMs inside of CAM: requests are queued and eventually they get tagged with an error when they complete.
It's also what the non-CAM drivers do when they have a work queue that needs to deal with resource shortages and limited queue depth.

Closed by commit rG86f8f5ccb798: vtblk: Make vtblk_request_execute return void. (authored by cperciva). · Explain WhyOct 18 2022, 6:03 AM

This revision was automatically updated to reflect the committed changes.

cperciva added a commit: rG86f8f5ccb798: vtblk: Make vtblk_request_execute return void..

Revision Contents
Changeset List

Path

Size

sys/

dev/

virtio/

block/

32 lines

Diff 110838

sys/dev/virtio/block/virtio_blk.c

Loading...