Page MenuHomeFreeBSD
Differential D36665

vtblk: Requeue inside vtblk_request_execute
ClosedPublic
Actions

Authored by cperciva on Sep 22 2022, 7:00 AM.
Tags
None
Referenced Files
F97645200: D36665.id.diff
Mon, Sep 30, 1:42 PM
F97643365: D36665.id111899.diff
Mon, Sep 30, 1:32 PM
F97643310: D36665.id110839.diff
Mon, Sep 30, 1:31 PM
Unknown Object (File)
Mon, Sep 30, 12:43 AM
Unknown Object (File)
Fri, Sep 27, 5:43 PM
Unknown Object (File)
Wed, Sep 25, 9:14 AM
Unknown Object (File)
Tue, Sep 24, 11:11 PM
Unknown Object (File)
Sun, Sep 22, 5:46 AM
View All 58 Files
Subscribers
imp

Details

Reviewers
bryanv
imp
Commits
rGcc25cfc9cf8a: vtblk: Requeue inside vtblk_request_execute
Summary

Most virtio_blk requests are launched from vtblk_startio; prior to this
commit, if vtblk_request_execute failed (e.g. due to a lack of space on
the virtio queue) vtblk_startio would requeue the request to be
reattempted later.

Add a flag "vbr_requeue_on_error" to requests and perform the requeuing
from inside vtblk_request_execute instead.

No functional change intended.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

cperciva created this revision.Sep 22 2022, 7:00 AM
Herald added a subscriber: imp. · View Herald TranscriptSep 22 2022, 7:00 AM
cperciva requested review of this revision.Sep 22 2022, 7:00 AM
cperciva added a parent revision: D36664: vtblk: Make vtblk_request_execute return void..
Harbormaster completed remote builds in B47486: Diff 110839.Sep 22 2022, 7:00 AM
cperciva added a child revision: D36666: vtblk: Include pointer to softc in request.Sep 22 2022, 7:01 AM
cperciva mentioned this in D36667: vtblk: Use busdma.Sep 22 2022, 7:03 AM
bryanv accepted this revision.Oct 3 2022, 3:19 AM
This revision is now accepted and ready to land.Oct 3 2022, 3:19 AM
imp accepted this revision.Oct 3 2022, 3:35 AM
imp added inline comments.
sys/dev/virtio/block/virtio_blk.c
1139

One can quibble over whether we should transition to bool for these, but the driver already has a few in the old-style.

Closed by commit rGcc25cfc9cf8a: vtblk: Requeue inside vtblk_request_execute (authored by cperciva). · Explain WhyOct 18 2022, 6:03 AM
This revision was automatically updated to reflect the committed changes.
cperciva added a commit: rGcc25cfc9cf8a: vtblk: Requeue inside vtblk_request_execute.

Revision Contents
Changeset List

PathSize
sys/
dev/
virtio/
block/
8 lines

Diff 111899

View Options

sys/dev/virtio/block/virtio_blk.c

Loading...