nfscl: Fix parameter order in the calls to MGET().
ClosedPublic
Actions

Authored by zlei on Sep 21 2022, 4:13 AM.

Details

Reviewers

ken
imp
rmacklem

Commits

rG8b43388c745e: nfscl: Fix parameter order in the calls to MGET().

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

zlei created this revision.Sep 21 2022, 4:13 AM

Herald added a subscriber: imp. · View Herald TranscriptSep 21 2022, 4:13 AM

zlei requested review of this revision.Sep 21 2022, 4:13 AM

Not at all sure how it works backwards like that....
But MT_DATA is 1 and M_NOWAIT is 1 also maybe?

This revision is now accepted and ready to land.Sep 21 2022, 2:28 PM

imp added a reviewer: rmacklem.Sep 21 2022, 2:29 PM

Yea, when the function gets called with M_WAITOK,
it sets the mbuf type to 2 (which does not seem to be
defined as a type and always did the call with M_NOWAIT.

I suspect an allocation failure with M_NOWAIT is rare and,
since the code checks for a NULL reply, it probably wasn't
breaking things badly.

However, it should obviously be fixed. Good catch!

I do not have direct access to the repository, @rmacklem may you please commit this?

In D36644#832674, @zlei.huang_gmail.com wrote:

I do not have direct access to the repository, @rmacklem may you please commit this?

I'd planned on doing it later today...

If Warner does it, that's great.
Otherwise, I'll do it someday soon.

Closed by commit rG8b43388c745e: nfscl: Fix parameter order in the calls to MGET(). (authored by zlei, committed by imp). · Explain WhySep 23 2022, 9:10 PM

This revision was automatically updated to reflect the committed changes.

imp added a commit: rG8b43388c745e: nfscl: Fix parameter order in the calls to MGET()..

Revision Contents
Changeset List

Path

Size

sys/

fs/

nfs/

nfs_commonsubs.c

2 lines

Diff 110889

View Options

sys/fs/nfs/nfs_commonsubs.c

nfscl: Fix parameter order in the calls to MGET().ClosedPublicActions