Differential D36488

tcp: avoid call to soisconnected() on transition to ESTABLISHED
ClosedPublic
Actions

Authored by glebius on Sep 7 2022, 10:41 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Mar 15, 9:45 AM

	Unknown Object (File)
	Mar 10 2025, 4:05 AM

	Unknown Object (File)
	Mar 8 2025, 5:59 PM

	Unknown Object (File)
	Mar 6 2025, 6:44 PM

	Unknown Object (File)
	Feb 23 2025, 7:28 PM

	Unknown Object (File)
	Feb 21 2025, 6:10 AM

	Unknown Object (File)
	Feb 16 2025, 8:49 PM

	Unknown Object (File)
	Jan 27 2025, 1:18 PM

View All 95 Files

Subscribers

Details

Reviewers

rrs
tuexen

Group Reviewers

Commits

rGe80062a2d433: tcp: avoid call to soisconnected() on transition to ESTABLISHED

Summary

This call existed since pre-FreeBSD times, and it is hard to understand
why it was there in the first place. After 6f3caa6d815 it definitely
became necessary always and commit message from f1ee30ccd60 confirms that.
Now that 6f3caa6d815 is effectively backed out by 07285bb4c22, the call
appears to be useful only for sockets that landed on the imcomplete queue,
e.g. sockets that have accept_filter(9) enabled on them.

Provide a new TCP flag to mark connections that are known to be on the
incomplete queue, and call soisconnected() only for those connections.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

glebius created this revision.Sep 7 2022, 10:41 PM

Herald added 1 blocking reviewer(s): transport. · View Herald TranscriptSep 7 2022, 10:41 PM

Herald added subscribers: melifaro, imp. · View Herald Transcript

glebius requested review of this revision.Sep 7 2022, 10:41 PM

Harbormaster completed remote builds in B47287: Diff 110333.Sep 7 2022, 10:41 PM

rrs accepted this revision.Sep 8 2022, 3:17 PM

This revision is now accepted and ready to land.Sep 8 2022, 3:17 PM

tuexen accepted this revision.Sep 8 2022, 3:18 PM

Closed by commit rGe80062a2d433: tcp: avoid call to soisconnected() on transition to ESTABLISHED (authored by glebius). · Explain WhySep 8 2022, 4:17 PM

This revision was automatically updated to reflect the committed changes.

glebius added a commit: rGe80062a2d433: tcp: avoid call to soisconnected() on transition to ESTABLISHED.

Revision Contents
Changeset List

Path

Size

sys/

kern/

8 lines

netinet/

5 lines

3 lines

4 lines

2 lines

sys/

2 lines

Diff 110359

sys/kern/uipc_socket.c

Loading...

sys/netinet/tcp_input.c

Loading...

sys/netinet/tcp_syncache.c

Loading...

sys/netinet/tcp_usrreq.c

Loading...

sys/netinet/tcp_var.h

Loading...

sys/sys/socketvar.h

Loading...