arm64 pmap: Convert PC_IS_FREE into an inline function.
ClosedPublic
Actions

Authored by jhb on Aug 16 2022, 5:15 PM.

Details

Reviewers

andrew
markj
manu

Commits

rG3499df29c2a1: arm64 pmap: Convert PC_IS_FREE into an inline function.

Summary

This permits inlining the comparisons even in the 16K page case.
Note that since PC_FREEN is -1, values can be compared efficiently
without having to fetch words of pc_freemask from memory via the
'cmn <reg>, #0x1' instruction.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 46959
Build 43848: arc lint + arc unit

Event Timeline

jhb created this revision.Aug 16 2022, 5:15 PM

Herald added a reviewer: manu. · View Herald TranscriptAug 16 2022, 5:15 PM

Herald added a subscriber: imp. · View Herald Transcript

jhb requested review of this revision.Aug 16 2022, 5:15 PM

Harbormaster completed remote builds in B46959: Diff 109396.Aug 16 2022, 5:15 PM

jhb added a parent revision: D36217: arm64 pmap: Simplify logic around pv_chunk sizes..Aug 16 2022, 5:15 PM

jhb mentioned this in D36214: Add a PC_IS_FULL macro to the arm64 pmap.Aug 16 2022, 5:17 PM

markj accepted this revision.Aug 16 2022, 6:14 PM

markj added inline comments.

sys/arm64/arm64/pmap.c
2480	Is pc_freemask unused?

This revision is now accepted and ready to land.Aug 16 2022, 6:14 PM

jhb added inline comments.Aug 16 2022, 6:48 PM

sys/arm64/arm64/pmap.c
2480	No, we still use it to initialize the mask in new chunks via memcpy.

Closed by commit rG3499df29c2a1: arm64 pmap: Convert PC_IS_FREE into an inline function. (authored by jhb). · Explain WhyAug 17 2022, 7:11 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rG3499df29c2a1: arm64 pmap: Convert PC_IS_FREE into an inline function..

Revision Contents
Changeset List

Path

Size

sys/

arm64/

pmap.c

21 lines

Diff 109396

View Options

arm64 pmap: Convert PC_IS_FREE into an inline function.ClosedPublicActions