loader: zfs reader should only store devdesc in f_devdata
ClosedPublic
Actions

Authored by tsoome on Aug 14 2022, 9:52 PM.

Details

Reviewers

Commits

rG03c44354fc9e: loader: zfs reader should only store devdesc in f_devdata
rGd98de7440507: loader: zfs reader should only store devdesc in f_devdata

Summary

Use d_opendata for device specific data.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

tsoome created this revision.Aug 14 2022, 9:52 PM

Herald added a reviewer: manu. · View Herald TranscriptAug 14 2022, 9:52 PM

Herald added subscribers: dab, delphij, imp. · View Herald Transcript

tsoome requested review of this revision.Aug 14 2022, 9:52 PM

Harbormaster completed remote builds in B46946: Diff 109349.Aug 14 2022, 9:52 PM

Seems reasonable, modulo the dangling XXX comment...

stand/libsa/zfs/zfs.c
1612	????

For me, when booting (amd64, BIOS boot) off ZFS, this clears the 'BTX halted' showstopper during early bootup.
UFS is not involved, installer media is unplugged.

Some console spam, from ffs_subr.c, is shown. Hyperlink to photo: https://plak.infrapuin.nl/selif/20220815135942copy1.jpg

In my automated testing, I don't see any of the reported spam and it works. I'll commit this shortly and let tsoome followup to deal with the 'when do we free' it issue that's still present, but mostly harmless for the environments that we'll be running in.

This revision was not accepted when it landed; it landed in state Needs Review.Aug 15 2022, 6:08 PM

Closed by commit rGd98de7440507: loader: zfs reader should only store devdesc in f_devdata (authored by tsoome). · Explain Why

This revision was automatically updated to reflect the committed changes.

tsoome added a commit: rGd98de7440507: loader: zfs reader should only store devdesc in f_devdata.

imp added a commit: rG03c44354fc9e: loader: zfs reader should only store devdesc in f_devdata.Jan 24 2023, 10:16 PM