Page MenuHomeFreeBSD
Differential D36120

ofed: allow using vlan interfaces for rdma
ClosedPublic
Actions

Authored by pkubaj on Aug 10 2022, 5:50 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Sep 24, 10:27 PM
Unknown Object (File)
Tue, Sep 24, 4:32 PM
Unknown Object (File)
Tue, Sep 24, 12:45 AM
Unknown Object (File)
Mon, Sep 23, 7:40 AM
Unknown Object (File)
Sat, Sep 21, 12:17 PM
Unknown Object (File)
Thu, Sep 19, 10:25 AM
Unknown Object (File)
Thu, Sep 19, 5:41 AM
Unknown Object (File)
Wed, Sep 18, 6:36 PM
View All 60 Files
Subscribers
imp

Details

Reviewers
bartosz.sobczak_intel.com
erj
• hselasky
Commits
rGeacf0dba236e: ibcore: Add support for RDMA/RoCE using VLAN(4) devices.
rG4149598b7a92: ibcore: Add support for RDMA/RoCE using VLAN(4) devices.
rG57af517ac4e8: ibcore: Add support for RDMA/RoCE using VLAN(4) devices.
Summary

Currently vlan interfaces can't use rdma, this change fixes it.

Test Plan

make kernel
reboot
rping -svda 100.0.0.226

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 46837
Build 43726: arc lint + arc unit

Event Timeline

pkubaj created this revision.Aug 10 2022, 5:50 PM
Herald added a subscriber: imp. · View Herald TranscriptAug 10 2022, 5:50 PM
pkubaj requested review of this revision.Aug 10 2022, 5:50 PM
Harbormaster completed remote builds in B46837: Diff 109111.Aug 10 2022, 5:50 PM
erj added a comment.Aug 10 2022, 6:03 PM

This seems like such a small change to enable such a large amount of functionality? Is it really that straightforward?

pkubaj added a comment.Aug 10 2022, 6:07 PM

Before this change, rping on vlan interfaces failed with:

created cm_id 0x80182e000
rdma_bind_addr: No such file or directory
destroy cm_id 0x80182e000

With this patch, it works.

• hselasky added a comment.Aug 10 2022, 8:52 PM

This will have to wait two weeks for review due to vacation!

Change looks OK, but I want to double check it a bit.

Thank you!

--HPS

• hselasky accepted this revision.Aug 22 2022, 7:51 AM
This revision is now accepted and ready to land.Aug 22 2022, 7:51 AM
Closed by commit rG57af517ac4e8: ibcore: Add support for RDMA/RoCE using VLAN(4) devices. (authored by • hselasky). · Explain WhyAug 22 2022, 8:06 AM
This revision was automatically updated to reflect the committed changes.
• hselasky added a commit: rG57af517ac4e8: ibcore: Add support for RDMA/RoCE using VLAN(4) devices..
pkubaj added a comment.Aug 22 2022, 8:39 PM

Uhm, you actually put wrong authorship (commit author, who is Bartosz Sobczak). I thought you would just accept this review and I would set it myself. I hope Bartosz is ok with losing copyright :)

• hselasky added a comment.Aug 22 2022, 9:33 PM

pkubaj: Sorry about that.

At least I got the differential revision right :-)

I'll send an e-mail out about that !

This is what vacation does to you ;-)

• hselasky added a comment.Aug 22 2022, 9:35 PM

I'll try to get that right when I MFC it!

• hselasky added a commit: rG4149598b7a92: ibcore: Add support for RDMA/RoCE using VLAN(4) devices..Aug 29 2022, 12:10 PM
• hselasky added a commit: rGeacf0dba236e: ibcore: Add support for RDMA/RoCE using VLAN(4) devices..

Revision Contents
Changeset List

PathSize
sys/
ofed/
drivers/
infiniband/
core/
2 lines

Diff 109111

View Options

sys/ofed/drivers/infiniband/core/ib_addr.c

Loading...