The two interrupt controllers which implement squelching of reports
after a maximum use the same limit. Move the limit to interrupt.h, the
better to encourage other interrupt controllers to implement the same.
Details
Details
- Reviewers
markj jhb jhibbits kib - Commits
- rGd8099e33c79b: intr: move MAX_STRAY_LOG to interrupt.h
Diff Detail
Diff Detail
- Repository
- rG FreeBSD src repository
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
sys/sys/interrupt.h | ||
---|---|---|
152 | IMO the constant should be renamed to indicate that it's in the "interrupt" namespace, somehow. I'd probably go with INTR_STRAY_LOG_MAX. |
Comment Actions
Always that warning about try compiling it first...
The other 3 occurances of MAX_STRAY_LOG need to be substituted with INTR_STRAY_LOG_MAX, but I wouldn't expect that to invalidate the point of the review (if someone wants the update on Phabricator, I can update).