Page MenuHomeFreeBSD

intr: move MAX_STRAY_LOG to interrupt.h
ClosedPublic

Authored by ehem_freebsd_m5p.com on Jun 20 2022, 1:58 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Nov 7, 5:10 PM
Unknown Object (File)
Sun, Oct 20, 11:57 PM
Unknown Object (File)
Sun, Oct 20, 11:55 PM
Unknown Object (File)
Sun, Oct 20, 11:55 PM
Unknown Object (File)
Fri, Oct 18, 6:50 PM
Unknown Object (File)
Oct 2 2024, 11:08 PM
Unknown Object (File)
Oct 1 2024, 5:31 AM
Unknown Object (File)
Sep 23 2024, 4:44 AM
Subscribers

Details

Summary

The two interrupt controllers which implement squelching of reports
after a maximum use the same limit. Move the limit to interrupt.h, the
better to encourage other interrupt controllers to implement the same.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

sys/sys/interrupt.h
152

IMO the constant should be renamed to indicate that it's in the "interrupt" namespace, somehow. I'd probably go with INTR_STRAY_LOG_MAX.

ehem_freebsd_m5p.com marked an inline comment as done.

Updating to match @markj's suggestion. Seems reasonable.

This revision is now accepted and ready to land.Jun 21 2022, 6:33 PM

Always that warning about try compiling it first...

The other 3 occurances of MAX_STRAY_LOG need to be substituted with INTR_STRAY_LOG_MAX, but I wouldn't expect that to invalidate the point of the review (if someone wants the update on Phabricator, I can update).

Always that warning about try compiling it first...

The other 3 occurances of MAX_STRAY_LOG need to be substituted with INTR_STRAY_LOG_MAX, but I wouldn't expect that to invalidate the point of the review (if someone wants the update on Phabricator, I can update).

Usually I wouldn't bother updating the review unless I plan to make further changes.

D35527 has been sitting here approved, but not in the main tree for quite some time. This is part of the "approved" branch on GitLab (git).

This revision was automatically updated to reflect the committed changes.