Page MenuHomeFreeBSD
Differential D35384

ifconfig.8: Prefer consistent terminologies
ClosedPublic
Actions

Authored by zlei on Jun 2 2022, 9:48 AM.
Tags
None
Referenced Files
F102447831: D35384.diff
Tue, Nov 12, 10:12 AM
Unknown Object (File)
Sun, Oct 20, 1:58 AM
Unknown Object (File)
Sun, Oct 20, 1:58 AM
Unknown Object (File)
Sun, Oct 20, 1:57 AM
Unknown Object (File)
Sun, Oct 20, 1:57 AM
Unknown Object (File)
Sun, Oct 20, 1:57 AM
Unknown Object (File)
Sun, Oct 20, 1:37 AM
Unknown Object (File)
Fri, Oct 18, 10:46 PM
View All 82 Files
Subscribers
imp

Details

Reviewers
0mp
pauamma_gundo.com
email_luiz.eng.br
Group Reviewers
manpages
Commits
rG52832592bd7d: ifconfig.8: Prefer consistent terminologies
rGccc48995c2cf: ifconfig.8: Prefer consistent terminologies

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

zlei created this revision.Jun 2 2022, 9:48 AM
Herald added a subscriber: imp. · View Herald TranscriptJun 2 2022, 9:48 AM
zlei requested review of this revision.Jun 2 2022, 9:48 AM
zlei added a child revision: D32820: vxlan: Add support for socket ioctls SIOC[SG]TUNFIB.
email_luiz.eng.br accepted this revision.Jun 2 2022, 10:11 AM
This revision is now accepted and ready to land.Jun 2 2022, 10:11 AM
zlei added a reviewer: manpages.Jun 2 2022, 10:42 AM
pauamma_gundo.com requested changes to this revision.Jun 2 2022, 11:11 PM
pauamma_gundo.com added inline comments.
sbin/ifconfig/ifconfig.8
410

Given FreeBSD hasn't supported Token Ring LANs for... IIRC over a decade? I'd remove that while here.

This revision now requires changes to proceed.Jun 2 2022, 11:11 PM
zlei updated this revision to Diff 106650.Jun 6 2022, 2:19 AM
zlei marked an inline comment as done.EditedJun 6 2022, 2:23 AM

@pauamma_gundo.com And what about the support status of FDDI ? It has been removed via D15017 and D15170 .

zlei added a parent revision: D35409: ifconfig.8: Update to reflect the removal of FDDI and Token Ring media support.Jun 6 2022, 8:12 AM
zlei retitled this revision from ifconfig.8: Prefer consistent terminology to ifconfig.8: Prefer consistent terminologies.
pauamma_gundo.com added a comment.Jun 9 2022, 8:14 AM
In D35384#802893, @zlei.huang_gmail.com wrote:

@pauamma_gundo.com And what about the support status of FDDI ? It has been removed via D15017 and D15170 .

Ooops, right. Remove FDDI too, then. I only remember FreeBSD TR support going away because I used to ride herd on a several thousand workstations TR network back when 8228s were the latest and greatest.

pauamma_gundo.com added a comment.Jun 9 2022, 7:09 PM
In D35384#803753, @pauamma_gundo.com wrote:

Ooops, right. Remove FDDI too, then. I only remember FreeBSD TR support going away because I used to ride herd on a several thousand workstations TR network back when 8228s were the latest and greatest.

Or are you planning to do that in D35409 instead?

zlei added a comment.EditedJun 10 2022, 1:52 AM
In D35384#803849, @pauamma_gundo.com wrote:
In D35384#803753, @pauamma_gundo.com wrote:

Ooops, right. Remove FDDI too, then. I only remember FreeBSD TR support going away because I used to ride herd on a several thousand workstations TR network back when 8228s were the latest and greatest.

Or are you planning to do that in D35409 instead?

Yes, I think they are left by D15017 and D15170, so fix it separately.

zlei updated this revision to Diff 106977.Jun 16 2022, 2:20 AM
zlei added a comment.Jun 16 2022, 2:22 AM

Ping @pauamma_gundo.com since the parent D35409 has been merged.

pauamma_gundo.com accepted this revision.Jun 17 2022, 1:54 AM
This revision is now accepted and ready to land.Jun 17 2022, 1:54 AM
zlei added a comment.Jun 17 2022, 6:39 AM

Hi @0mp , do you have any objections ?

zlei added a comment.Jun 29 2022, 4:58 AM

Ping @0mp

Closed by commit rGccc48995c2cf: ifconfig.8: Prefer consistent terminologies (authored by zlei, committed by 0mp). · Explain WhyJun 29 2022, 6:59 AM
This revision was automatically updated to reflect the committed changes.
0mp added a commit: rGccc48995c2cf: ifconfig.8: Prefer consistent terminologies.
zlei added a comment.Jun 29 2022, 10:39 AM

@0mp Thanks!

zlei mentioned this in D32820: vxlan: Add support for socket ioctls SIOC[SG]TUNFIB.Jun 29 2022, 10:41 AM
0mp added a commit: rG52832592bd7d: ifconfig.8: Prefer consistent terminologies.Jul 21 2022, 11:57 PM

Revision Contents
Changeset List

PathSize
sbin/
ifconfig/
8 lines

Diff 106564

View Options

sbin/ifconfig/ifconfig.8

Loading...