Finish removing FDDI and tokenring media support.
ClosedPublic
Actions

Authored by brooks on Apr 23 2018, 3:34 PM.

Details

Reviewers

zeising
emaste
kib
marieheleneka_gmail.com

Commits

rS332895: Finish removing FDDI and tokenring media support.

Summary

This fixes media display for 802.11 wireless devices.

Software outside the base system that uses these media types and typedefs should use #ifdef IFM_FDDI or IFM_TOKEN to include or remove support.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

brooks created this revision.Apr 23 2018, 3:34 PM

Herald added a subscriber: ae. · View Herald TranscriptApr 23 2018, 3:34 PM

Harbormaster completed remote builds in B16265: Diff 41763.Apr 23 2018, 3:34 PM

Hi!
It fixes my usecase (ifconfig displays the correct, or at least more correct than before, info about the media).
I've tested by checking out the source tree at the same version as my kernel, r332854, and then done a buildworld without some of the heavier components (toolchain, profiled libs and lib32) and run the resulting ifconfig binary from the obj tree.
Thanks for getting to it so fast!
Let me know if you want me to test other use cases.
Regards

This revision is now accepted and ready to land.Apr 23 2018, 5:47 PM

brooks edited the summary of this revision. (Show Details)Apr 23 2018, 6:33 PM

brooks edited the summary of this revision. (Show Details)

brooks added reviewers: emaste, kib.Apr 23 2018, 6:48 PM

emaste accepted this revision.Apr 23 2018, 7:31 PM

kib accepted this revision.Apr 23 2018, 8:21 PM

Closed by commit rS332895: Finish removing FDDI and tokenring media support. (authored by brooks). · Explain WhyApr 23 2018, 9:10 PM

This revision was automatically updated to reflect the committed changes.

Herald added a reviewer: marieheleneka_gmail.com. · View Herald TranscriptApr 23 2018, 9:10 PM

Herald added a subscriber: imp. · View Herald Transcript

zlei mentioned this in D35384: ifconfig.8: Prefer consistent terminologies.Jun 6 2022, 2:23 AM