Page MenuHomeFreeBSD

libm: Add feenableexcept and fedisableexcept to library on powerpc
ClosedPublic

Authored by jhibbits on May 13 2022, 10:26 PM.
Tags
None
Referenced Files
F102864947: D35204.diff
Mon, Nov 18, 4:17 AM
Unknown Object (File)
Sun, Nov 3, 4:56 AM
Unknown Object (File)
Sun, Nov 3, 4:56 AM
Unknown Object (File)
Sun, Nov 3, 4:52 AM
Unknown Object (File)
Sun, Nov 3, 4:44 AM
Unknown Object (File)
Mon, Oct 21, 5:39 AM
Unknown Object (File)
Oct 4 2024, 11:30 PM
Unknown Object (File)
Oct 3 2024, 2:00 AM
Subscribers
None

Details

Summary

These functions are missing from the library itself, and exist solely in
the header. This breaks a few ports that expect libm to have the
symbols in the library itself.

Questions on MFC-ability: Can this be MFC'd to 13.2, and how?

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 45574
Build 42462: arc lint + arc unit

Event Timeline

jhibbits created this revision.

You just merge it when you think that there is enough testing done in head, as usual. Or, is there some more background context I am not aware of?

lib/msun/powerpc/fenv.h
267

This comment should be moved down, perhaps?

This revision is now accepted and ready to land.May 14 2022, 12:53 AM

I wasn't sure about adding new functions to libraries in stable/ branches, particularly to notify ports of the existence. I see now that stable/13 has the FBSD_1.7 in the top level Symbol.map anyway, so no issue.