Page MenuHomeFreeBSD
Differential D35198

sysvsem: Fix a typo.
ClosedPublic
Actions

Authored by dchagin on May 13 2022, 5:30 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Nov 17, 9:33 PM
Unknown Object (File)
Mon, Oct 28, 10:58 PM
Unknown Object (File)
Oct 18 2024, 4:09 AM
Unknown Object (File)
Oct 8 2024, 1:38 PM
Unknown Object (File)
Oct 2 2024, 4:58 PM
Unknown Object (File)
Oct 1 2024, 5:39 PM
Unknown Object (File)
Oct 1 2024, 11:29 AM
Unknown Object (File)
Sep 28 2024, 2:28 AM
View All 39 Files
Subscribers
imp

Details

Reviewers
jamie
Commits
rG2fe96ee7537b: sysvsem: Fix a typo
rGcb2ae6163174: sysvsem: Fix a typo

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 45567
Build 42455: arc lint + arc unit

Event Timeline

dchagin created this revision.May 13 2022, 5:30 PM
Herald added a subscriber: imp. · View Herald TranscriptMay 13 2022, 5:30 PM
dchagin requested review of this revision.May 13 2022, 5:30 PM
Harbormaster completed remote builds in B45567: Diff 105952.May 13 2022, 5:30 PM
dchagin added a reviewer: jamie.May 13 2022, 5:51 PM
dchagin changed the repository for this revision from rS FreeBSD src repository - subversion to rG FreeBSD src repository.
jamie accepted this revision.May 13 2022, 8:04 PM

Wow, that has been there for an embarrassingly long time!

This revision is now accepted and ready to land.May 13 2022, 8:04 PM
dchagin added a comment.May 13 2022, 8:54 PM
In D35198#797888, @jamie wrote:

Wow, that has been there for an embarrassingly long time!

Well, it's not a bug)) because the rpr cannot be NULL AFAIR, or Im missed something?

jamie added a comment.May 13 2022, 9:09 PM
In D35198#797902, @dchagin wrote:
In D35198#797888, @jamie wrote:

Wow, that has been there for an embarrassingly long time!

Well, it's not a bug)) because the rpr cannot be NULL AFAIR, or Im missed something?

Actually, it is - perhaps. rpr can be null if the jail is created with sysvsem=disable. But at least it doesn't appear to be fatal, since rpr is never dereferenced (as far as a quick glance suggests) but is only compared to other prison pointers. It might even end up doing the right thing without the null check, but I wouldn't want to count on it.

Closed by commit rGcb2ae6163174: sysvsem: Fix a typo (authored by dchagin). · Explain WhyMay 14 2022, 11:08 AM
This revision was automatically updated to reflect the committed changes.
dchagin added a commit: rGcb2ae6163174: sysvsem: Fix a typo.
dchagin added a commit: rG2fe96ee7537b: sysvsem: Fix a typo.Jun 17 2022, 7:45 PM

Revision Contents
Changeset List

PathSize
sys/
kern/
4 lines

Diff 105952

View Options

sys/kern/sysv_sem.c

Loading...