Page MenuHomeFreeBSD
Differential D34824

if_bnxt: Allow bnxt interfaces to use vlans with promisc mode
ClosedPublic
Actions

Authored by thj on Apr 7 2022, 4:35 PM.
Tags
None
Referenced Files
F95812341: D34824.diff
Sun, Sep 22, 6:10 PM
Unknown Object (File)
Sat, Sep 21, 1:22 AM
Unknown Object (File)
Fri, Sep 20, 10:32 AM
Unknown Object (File)
Fri, Sep 20, 4:10 AM
Unknown Object (File)
Thu, Sep 19, 10:16 AM
Unknown Object (File)
Wed, Sep 18, 12:57 PM
Unknown Object (File)
Wed, Sep 18, 4:25 AM
Unknown Object (File)
Wed, Sep 18, 2:19 AM
View All 60 Files
Subscribers
imp
pi

Details

Reviewers
shurd
allanjude
rpokala
mav
Group Reviewers
network
Klara
Commits
rG5acfa48bb258: if_bnxt: Allow bnxt interfaces to use vlans
rGe54505277c39: if_bnxt: Allow bnxt interfaces to use vlans
rG0c6a2fa33e36: if_bnxt: Allow bnxt interfaces to use vlans
Summary
  • Add patch 203393 from Stephen Hurd
  • Add patch 229498 from misho

These patches are from this bz thread:
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=236983

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 45056
Build 41944: arc lint + arc unit

Event Timeline

thj created this revision.Apr 7 2022, 4:35 PM
Herald added a subscriber: imp. · View Herald TranscriptApr 7 2022, 4:35 PM
thj requested review of this revision.Apr 7 2022, 4:35 PM
Harbormaster completed remote builds in B45056: Diff 104729.Apr 7 2022, 4:35 PM
thj added a reviewer: mav.Apr 7 2022, 4:50 PM
thj added a reviewer: rpokala.Apr 7 2022, 4:54 PM
mav resigned from this revision.Apr 7 2022, 5:15 PM

I am not really familiar with this hardware to review this. Only fixed couple mechanical issues.

pi added a subscriber: pi.Apr 7 2022, 6:16 PM

Tested, packets only flow if interface is in promisc mode. The patch from

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=236983#c23

works without the promisc.

thj updated this revision to Diff 104912.Apr 12 2022, 4:46 PM

With just misho's patch from bz

Harbormaster completed remote builds in B45127: Diff 104912.Apr 12 2022, 4:46 PM
This revision was not accepted when it landed; it landed in state Needs Review.Apr 21 2022, 8:32 AM
Closed by commit rG0c6a2fa33e36: if_bnxt: Allow bnxt interfaces to use vlans (authored by misho_elwix.org, committed by thj). · Explain Why
This revision was automatically updated to reflect the committed changes.
thj added a commit: rG0c6a2fa33e36: if_bnxt: Allow bnxt interfaces to use vlans.
thj added a commit: rGe54505277c39: if_bnxt: Allow bnxt interfaces to use vlans.Apr 27 2022, 1:16 PM
thj added a commit: rG5acfa48bb258: if_bnxt: Allow bnxt interfaces to use vlans.Apr 27 2022, 1:56 PM

Revision Contents
Changeset List

PathSize
sys/
dev/
bnxt/
23 lines

Diff 104729

View Options

sys/dev/bnxt/if_bnxt.c

Loading...