linuxkpi: Move cdev_alloc into .c file
ClosedPublic
Actions

Authored by imp on Apr 4 2022, 5:03 PM.

Details

Reviewers

• hselasky
emaste

Commits

rG88543510cc72: linuxkpi: Move cdev_alloc into .c file
rGd1f93d6721a6: linuxkpi: Move cdev_alloc into .c file
rGaca0bcbca344: linuxkpi: Move cdev_alloc into .c file

Summary

Move cdev_alloc into linux_compat.c since it encodes the size of struct
linux_cdev into the client modules otherwise.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 44989
Build 41877: arc lint + arc unit

Event Timeline

imp created this revision.Apr 4 2022, 5:03 PM

Herald added subscribers: linuxkpi, emaste. · View Herald TranscriptApr 4 2022, 5:03 PM

imp requested review of this revision.Apr 4 2022, 5:03 PM

Harbormaster completed remote builds in B44989: Diff 104569.Apr 4 2022, 5:03 PM

imp added a parent revision: D34770: linuxkpi: Remove write only variable from lkpi_iicbb_reset.Apr 4 2022, 5:03 PM

imp added a child revision: D34772: linuxkpi: Move lkpi_pci_devres_get_alloc into .c file.

And check LINT.

This revision is now accepted and ready to land.Apr 4 2022, 5:18 PM

emaste accepted this revision.Apr 4 2022, 5:20 PM

emaste added inline comments.

sys/compat/linuxkpi/common/src/linux_compat.c
610	same (aside) comment as another review, curious how FreeBSD M_* and Linux flags interact

imp added inline comments.Apr 4 2022, 8:06 PM

sys/compat/linuxkpi/common/src/linux_compat.c
610	Yea, it's funky... But presumably it's working code and I'm just copying from one file to another...

Closed by commit rGaca0bcbca344: linuxkpi: Move cdev_alloc into .c file (authored by imp). · Explain WhyApr 5 2022, 5:10 AM

This revision was automatically updated to reflect the committed changes.

imp added a commit: rGaca0bcbca344: linuxkpi: Move cdev_alloc into .c file.

imp added a commit: rGd1f93d6721a6: linuxkpi: Move cdev_alloc into .c file.Apr 5 2022, 2:43 PM

imp added a commit: rG88543510cc72: linuxkpi: Move cdev_alloc into .c file.Apr 6 2022, 5:46 PM

Revision Contents
Changeset List

Path

Size

sys/

compat/

linuxkpi/

common/

include/

linux/

cdev.h

13 lines

src/

linux_compat.c

11 lines

Diff 104569

View Options

sys/compat/linuxkpi/common/include/linux/cdev.h