linuxkpi: Move class_create to .c file
ClosedPublic
Actions

Authored by imp on Apr 4 2022, 5:03 PM.

Details

Reviewers

• hselasky
emaste

Commits

rG169aa349594c: linuxkpi: Move class_create to .c file
rG98d2b4a158f1: linuxkpi: Move class_create to .c file
rG1341ac9f9c11: linuxkpi: Move class_create to .c file

Summary

class_create encodes the size of struct class into the generated
code. Move from .h file to .c file to move this knowledge from the
client modules that call this into the linuxkpi module.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

imp created this revision.Apr 4 2022, 5:03 PM

Herald added subscribers: linuxkpi, emaste. · View Herald TranscriptApr 4 2022, 5:03 PM

imp requested review of this revision.Apr 4 2022, 5:03 PM

Harbormaster completed remote builds in B44987: Diff 104567.Apr 4 2022, 5:03 PM

imp added a parent revision: D34768: linuxkpi: Move device_create_groups_vargs to linux_compat.c.Apr 4 2022, 5:03 PM

imp added a child revision: D34770: linuxkpi: Remove write only variable from lkpi_iicbb_reset.

Make sure LINT passes, and that there are no conflicts with existing global symbols.

This revision is now accepted and ready to land.Apr 4 2022, 5:16 PM

emaste accepted this revision.Apr 4 2022, 5:17 PM

emaste added inline comments.

sys/compat/linuxkpi/common/src/linux_compat.c
505	how do Linux and FreeBSD flags interact?

• hselasky added inline comments.Apr 4 2022, 5:26 PM

sys/compat/linuxkpi/common/src/linux_compat.c
505	Yes. Can be changed to GFP_KERNEL .

imp added inline comments.Apr 4 2022, 8:10 PM

sys/compat/linuxkpi/common/src/linux_compat.c
505	I'm nervous about making any changes here... At least with the pure move it commits... I'll do a grep for kzalloc to see what else is doing naughty things.