stge_attach() could fail at line 464, sc->sc_spec remains NULL when
calling stge_detach(), thus bus_release_resources() at line 704 will
trigger null pointer dereference. We need to check the nulliness before
calling bus_release_resources().
Details
Details
Diff Detail
Diff Detail
- Lint
Lint Skipped - Unit
Tests Skipped
Event Timeline
Comment Actions
Dear Reviewers,
I was doing some code review and found some issues in the NIC driver.
I am a completely newbie and I'd appreciate it if someone could give some comments on the patch.
Thanks and have a good one.
- Tong
Comment Actions
The patch seems ok, but here are some general comments:
- When uploading raw patches directly to phabricator, please upload with full context per https://wiki.freebsd.org/Phabricator#Create_a_Revision_via_Web_Interface
- This is a very old driver that does not get any maintenance, and I can't see any evidence that any users of the driver, if any, have actually hit this bug. So there will be very little interest in merging such patches.