[PATCH] stge: fix null pointer dereference
ClosedPublic
Actions

Authored by ztong0001_gmail.com on Mar 21 2022, 9:00 PM.

Details

Reviewers

imp
mjg
kaktus
glebius
mmacy
pfg
rwatson
dim
csjp
markj

Group Reviewers

network

Commits

rG2108cc72906f: stge: fix null pointer dereference

Summary

stge_attach() could fail at line 464, sc->sc_spec remains NULL when
calling stge_detach(), thus bus_release_resources() at line 704 will
trigger null pointer dereference. We need to check the nulliness before
calling bus_release_resources().

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ztong0001_gmail.com requested review of this revision.Mar 21 2022, 9:00 PM

ztong0001_gmail.com created this revision.

ztong0001_gmail.com set the repository for this revision to rG FreeBSD src repository.Mar 21 2022, 9:11 PM

Herald added a subscriber: imp. · View Herald TranscriptMar 21 2022, 9:11 PM

ztong0001_gmail.com added a reviewer: imp.Mar 22 2022, 12:28 AM

ztong0001_gmail.com added reviewers: kib, mjg.Mar 25 2022, 6:07 PM

ztong0001_gmail.com added reviewers: kaktus, glebius, mmacy.

ztong0001_gmail.com added a reviewer: network.Mar 28 2022, 5:31 PM

Dear Reviewers,
I was doing some code review and found some issues in the NIC driver.
I am a completely newbie and I'd appreciate it if someone could give some comments on the patch.
Thanks and have a good one.

Tong

ztong0001_gmail.com edited reviewers, added: pfg, rwatson, dim, csjp; removed: kib.Mar 29 2022, 6:22 AM

ztong0001_gmail.com retitled this revision from stge: fix null pointer dereference to [PATCH] stge: fix null pointer dereference.

The patch seems ok, but here are some general comments:

When uploading raw patches directly to phabricator, please upload with full context per https://wiki.freebsd.org/Phabricator#Create_a_Revision_via_Web_Interface
This is a very old driver that does not get any maintenance, and I can't see any evidence that any users of the driver, if any, have actually hit this bug. So there will be very little interest in merging such patches.

This revision is now accepted and ready to land.Mar 31 2022, 6:06 PM

Closed by commit rG2108cc72906f: stge: fix null pointer dereference (authored by ztong0001_gmail.com, committed by markj). · Explain WhyMar 31 2022, 8:01 PM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rG2108cc72906f: stge: fix null pointer dereference.