hda: add patch for Framework laptop headphone jack
ClosedPublic
Actions

Authored by emaste on Mar 17 2022, 10:58 PM.

Details

Reviewers

markj
delphij

Commits

rGff73087a897c: hda: add patch for Framework laptop headphone jack
rG06731139ca52: hda: add patch for Framework laptop headphone jack

Summary

For Framework laptops from Oct 2022 that have a Tempo Semiconductor 92HD95B codec.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

emaste requested review of this revision.Mar 17 2022, 10:58 PM

emaste created this revision.

sys/dev/sound/pci/hda/hdac.h
506	It's unfortunate that these seem to be in no real order, and also these are actually subvendor IDs AFAICT.

I think I can't really review this without seeing pin configurations. Can you paste sysctl dev.hdaa.0 output somewhere so I can compare with my laptop?

https://termbin.com/acjk

Seems ok to me. My laptop needs a different patch, I'll work on it tomorrow.

This revision is now accepted and ready to land.Mar 17 2022, 11:14 PM

emaste added inline comments.Mar 17 2022, 11:14 PM

sys/dev/sound/pci/hda/hdaa_patches.c
329	I guess this could also have `color=Black loc=Left`

Closed by commit rG06731139ca52: hda: add patch for Framework laptop headphone jack (authored by emaste). · Explain WhyMar 17 2022, 11:28 PM

This revision was automatically updated to reflect the committed changes.

emaste added a commit: rG06731139ca52: hda: add patch for Framework laptop headphone jack.

Herald added a subscriber: imp. · View Herald TranscriptMar 17 2022, 11:28 PM

emaste added a commit: rGff73087a897c: hda: add patch for Framework laptop headphone jack.Mar 24 2022, 1:58 PM

timp87_gmail.com mentioned this in D36354: hda: add patch for Framework laptop v2 headphone jack.Aug 26 2022, 2:17 AM

Revision Contents
Changeset List

Path

Size

sys/

dev/

sound/

pci/

hda/

hdaa_patches.c

7 lines

hdac.h

4 lines

Diff 103969

View Options

sys/dev/sound/pci/hda/hdaa_patches.c