Page MenuHomeFreeBSD

namei: Treat non-tied KLDs as if they had INVARIANTS enabled
ClosedPublic

Authored by gallatin on Mar 17 2022, 2:45 PM.
Tags
None
Referenced Files
F98569281: D34588.diff
Thu, Oct 3, 9:25 PM
Unknown Object (File)
Tue, Oct 1, 11:59 AM
Unknown Object (File)
Tue, Sep 24, 8:11 PM
Unknown Object (File)
Mon, Sep 23, 7:10 PM
Unknown Object (File)
Fri, Sep 20, 4:44 PM
Unknown Object (File)
Fri, Sep 20, 9:15 AM
Unknown Object (File)
Fri, Sep 20, 8:44 AM
Unknown Object (File)
Thu, Sep 19, 1:25 PM
Subscribers

Details

Summary

When working with a vendor to debug their kernel module, I found that a non-tied kld will panic due to "namei: bad debugflags " on a kernel compiled with INVARIANTS because non-tied KLDs do not pick up the initialization that is done in NDINIT_DBG/NDREINIT_DBG().

Fix this by making this initialization happen for non- KLD_TIED as well as INVARIANTS

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

this needs a comment what the hack is for, as in how come this is not picked up automatically

  • Added a comment to why we enable debug stuff here as per mjg's request
This revision is now accepted and ready to land.Mar 17 2022, 5:34 PM