Differential D34536

<sys/reg.h>: Add ELF32_REGSET.
ClosedPublic
Actions

Authored by jhb on Mar 12 2022, 12:44 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Oct 1, 1:53 AM

	Unknown Object (File)
	Thu, Sep 19, 5:33 AM

	Unknown Object (File)
	Wed, Sep 18, 7:19 PM

	Unknown Object (File)
	Wed, Sep 18, 8:34 AM

	Unknown Object (File)
	Wed, Sep 18, 2:30 AM

	Unknown Object (File)
	Mon, Sep 16, 9:21 PM

	Unknown Object (File)
	Sun, Sep 15, 9:00 PM

	Unknown Object (File)
	Sun, Sep 15, 12:54 AM

View All 47 Files

Subscribers

Details

Reviewers

andrew
markj

Commits

rG717cf1d3e45f: <sys/reg.h>: Add ELF32_REGSET.
rGb1cd03dd2989: <sys/reg.h>: Add ELF32_REGSET.

Summary

This permits adding a register set for FREEBSD32 ABIs.

While here, include <sys/linker_set.h> to make this header more
self-contained in the kernel.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb created this revision.Mar 12 2022, 12:44 AM

Herald added a subscriber: imp. · View Herald TranscriptMar 12 2022, 12:44 AM

jhb requested review of this revision.Mar 12 2022, 12:44 AM

Harbormaster completed remote builds in B44746: Diff 103773.Mar 12 2022, 12:44 AM

jhb added a child revision: D34448: Use a regset for NT_ARM_VFP..Mar 12 2022, 12:45 AM

andrew added inline comments.Mar 14 2022, 2:50 PM

sys/sys/reg.h
61	Do we need this? It will just declare one of the below sets that could be moved up.

jhb added inline comments.Mar 14 2022, 9:00 PM

sys/sys/reg.h
61	We still end up sing ELF_REGSET rather than ELF<nn>_REGSET in most places. But I guess it's true that we might not need the SET_DECLARE, per se. Possibly I should just add ELF32_REGSET under COMPAT_FREEBSD32 and leave ELF64_REGSET for use in CheriBSD for now.

markj accepted this revision.Mar 14 2022, 10:15 PM

This revision is now accepted and ready to land.Mar 14 2022, 10:15 PM

jhb retitled this revision from <sys/reg.h>: Add ELF32_REGSET and ELF64_REGSET. to <sys/reg.h>: Add ELF32_REGSET..Mar 17 2022, 9:57 PM

jhb edited the summary of this revision. (Show Details)

Just add ELF32_REGSET for now.

This revision now requires review to proceed.Mar 17 2022, 9:58 PM

Harbormaster completed remote builds in B44813: Diff 103962.Mar 17 2022, 9:58 PM

markj accepted this revision.Mar 17 2022, 10:33 PM

This revision is now accepted and ready to land.Mar 17 2022, 10:33 PM

andrew accepted this revision.Mar 18 2022, 11:15 AM

Closed by commit rGb1cd03dd2989: <sys/reg.h>: Add ELF32_REGSET. (authored by jhb). · Explain WhyMar 23 2022, 8:33 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rGb1cd03dd2989: <sys/reg.h>: Add ELF32_REGSET..

jhb added a commit: rG717cf1d3e45f: <sys/reg.h>: Add ELF32_REGSET..May 13 2022, 5:43 PM

Revision Contents
Changeset List

Path

Size

sys/

sys/

6 lines

Diff 104128

sys/sys/reg.h

Loading...