Stop adding -Wredundant-decls to CWARNFLAGS.
ClosedPublic
Actions

Authored by jhb on Feb 2 2022, 8:20 PM.

Details

Reviewers

emaste
imp

Commits

rG429d95658672: Stop adding -Wredundant-decls to CWARNFLAGS.
rG419f53cb21eb: Stop adding -Wredundant-decls to CWARNFLAGS.
rGc227269e2f9d: Stop adding -Wredundant-decls to CWARNFLAGS.

Summary

clang doesn't implement it, and for GCC we've had to neuter it, so
setting it explicitly does not add any gain.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb created this revision.Feb 2 2022, 8:20 PM

Herald added subscribers: jhibbits, bdrewery. · View Herald TranscriptFeb 2 2022, 8:20 PM

jhb requested review of this revision.Feb 2 2022, 8:20 PM

Harbormaster completed remote builds in B44251: Diff 102272.Feb 2 2022, 8:20 PM

Without this change GCC currently warns though?

In D34144#772331, @emaste wrote:

Without this change GCC currently warns though?

Yes. I've fixed a few places in the past, but more keep cropping up, and upstream code in linux from linuxkpi, iwlwifi, etc. is the source of some issues because Linux doesn't care about it either. I think clang will warn if you have redundant declarations that conflict.