ufs, msdosfs: do not record witness order when creating vnode
ClosedPublic
Actions

Authored by kib on Feb 1 2022, 5:20 AM.

Tags

None

Referenced Files

	F107297913: D34126.diff
	Sun, Jan 12, 4:16 AM

	Unknown Object (File)
	Mon, Dec 16, 5:43 AM

	Unknown Object (File)
	Nov 30 2024, 7:57 PM

	Unknown Object (File)
	Nov 26 2024, 8:36 AM

	Unknown Object (File)
	Oct 7 2024, 7:09 PM

	Unknown Object (File)
	Sep 19 2024, 1:28 PM

	Unknown Object (File)
	Sep 18 2024, 1:44 PM

	Unknown Object (File)
	Sep 17 2024, 8:23 PM

View All 37 Files

Subscribers

imp

Details

Reviewers

mckusick
markj

Commits

rG303d3ae7e841: ufs, msdosfs: do not record witness order when creating vnode
rGd51b0786a2f6: msdosfs_denode.c: some style

Summary

When allocating new vnode, we need to lock it exclusively before
making it externally visible.  Since other threads cannot observe the
vnode yet, current lock order cannot create LoR conditions.

msdosfs_denode.c: some style

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

kib created this revision.Feb 1 2022, 5:20 AM

Herald added a subscriber: imp. · View Herald TranscriptFeb 1 2022, 5:20 AM

kib requested review of this revision.Feb 1 2022, 5:20 AM

I agree with this change.

This revision is now accepted and ready to land.Feb 1 2022, 7:38 AM

Closed by commit rGd51b0786a2f6: msdosfs_denode.c: some style (authored by kib). · Explain WhyFeb 1 2022, 9:03 AM

This revision was automatically updated to reflect the committed changes.

kib added a commit: rGd51b0786a2f6: msdosfs_denode.c: some style.

kib added a commit: rG303d3ae7e841: ufs, msdosfs: do not record witness order when creating vnode.

Revision Contents
Changeset List

Path

Size

sys/

fs/

msdosfs/

msdosfs_denode.c

12 lines

ufs/

ffs/

ffs_vfsops.c

2 lines

Diff 102202

View Options

sys/fs/msdosfs/msdosfs_denode.c