Differential D34122

<sys/bitstring.h>: Cast _BITSTR_BITS to int in a ternary operator.
ClosedPublic
Actions

Authored by jhb on Feb 1 2022, 1:08 AM.

Tags

None

Referenced Files

	F102194191: D34122.diff
	Fri, Nov 8, 7:04 PM

	Unknown Object (File)
	Thu, Nov 7, 2:02 PM

	Unknown Object (File)
	Wed, Nov 6, 4:34 AM

	Unknown Object (File)
	Sun, Nov 3, 8:44 AM

	Unknown Object (File)
	Fri, Nov 1, 3:46 AM

	Unknown Object (File)
	Sun, Oct 13, 8:22 PM

	Unknown Object (File)
	Sep 27 2024, 8:54 AM

	Unknown Object (File)
	Sep 11 2024, 8:10 PM

View All 48 Files

Subscribers

Details

Reviewers

rlibby
dougm

Commits

rG897877ae644d: <sys/bitstring.h>: Cast _BITSTR_BITS to int in a ternary operator.
rG8a67a1a9646e: <sys/bitstring.h>: Cast _BITSTR_BITS to int in a ternary operator.

Summary

This fixes a -Wsign-compare error reported by GCC due to the two
results of the ternary operator having differing signedness.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 44208
Build 41096: arc lint + arc unit

Event Timeline

jhb created this revision.Feb 1 2022, 1:08 AM

Herald added a subscriber: imp. · View Herald TranscriptFeb 1 2022, 1:08 AM

jhb requested review of this revision.Feb 1 2022, 1:08 AM

Harbormaster completed remote builds in B44208: Diff 102190.Feb 1 2022, 1:08 AM

rlibby accepted this revision.Feb 1 2022, 1:46 AM

This revision is now accepted and ready to land.Feb 1 2022, 1:46 AM

dougm accepted this revision.Feb 1 2022, 6:00 AM

Closed by commit rG8a67a1a9646e: <sys/bitstring.h>: Cast _BITSTR_BITS to int in a ternary operator. (authored by jhb). · Explain WhyFeb 1 2022, 5:45 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rG8a67a1a9646e: <sys/bitstring.h>: Cast _BITSTR_BITS to int in a ternary operator..

dougm added a commit: rG897877ae644d: <sys/bitstring.h>: Cast _BITSTR_BITS to int in a ternary operator..Jul 11 2022, 6:09 AM

Revision Contents
Changeset List

Path

Size

sys/

sys/

2 lines

Diff 102190

sys/sys/bitstring.h

Loading...