Add three hooks to the livedump process: before, after, and for each
block of dumped data. This allows, for example, quiescing the system
before the dump begins or protecting data of interest to ensure its
consistency in the final output.
Details
Details
- Reviewers
markj kib debdrup pauamma_gundo.com - Group Reviewers
manpages - Commits
- rG13f544bc8e9f: livedump: add event handler hooks
rGeb9d205fa691: livedump: add event handler hooks
Diff Detail
Diff Detail
- Repository
- rG FreeBSD src repository
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
Change language grammar and spelling LGTM. I'll let others check consistency with source code.
share/man/man9/EVENTHANDLER.9 | ||
---|---|---|
328 | Since you're touching this section |
sys/kern/kern_vnodedumper.c | ||
---|---|---|
60 | How could this declaration used? It is only available in this .c file, so all users must be in this .c file as well. Then why not call them directly, instead of using the machinery of eventhandlers? |
sys/kern/kern_vnodedumper.c | ||
---|---|---|
121–123 | Save the minidumpsys() error in a separate variable? Why is it useful to allow the _finish handlers to return an error? |
share/man/man9/EVENTHANDLER.9 | ||
---|---|---|
324 | Might want to s/minidump/kernel dump/ per the discussion in the vnode dumper review. |