Page MenuHomeFreeBSD

mkisoimages.sh: Avoid creating temporary files in the current directory
ClosedPublic

Authored by jrtc27 on Jan 22 2022, 1:18 AM.
Tags
None
Referenced Files
F109602707: D33998.diff
Fri, Feb 7, 7:40 AM
Unknown Object (File)
Sat, Feb 1, 11:35 PM
Unknown Object (File)
Fri, Jan 17, 9:09 PM
Unknown Object (File)
Dec 13 2024, 3:45 AM
Unknown Object (File)
Dec 2 2024, 1:57 PM
Unknown Object (File)
Oct 25 2024, 4:39 AM
Unknown Object (File)
Oct 25 2024, 4:39 AM
Unknown Object (File)
Oct 25 2024, 4:39 AM

Details

Summary

Currently the current directory is the parent of the rootfs directory,
but this will change in order to support NO_ROOT builds that use a
metalog manifest, since those need to have the current directory be the
rootfs itself in order for the relative paths to be correct, and we do
not want the non-METALOG case (which passes the directory to makefs) to
pick up leftover temporary .img files from a previous failed build.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

brooks added a subscriber: brooks.

I wonder if these want a trap or exit handler

This revision is now accepted and ready to land.Jan 22 2022, 6:47 PM

I wonder if these want a trap or exit handler

The make-memstick.sh's all document that they deliberately don't clean up on error in order to aid in debugging what went wrong. Presumably mkisoimages.sh is the same, just without documenting it (though whether that was the original intent, who knows).