Page MenuHomeFreeBSD
Differential D33810

vm_pageout: Print a more accurate message to the console before an OOM kill
ClosedPublic
Actions

Authored by markj on Jan 10 2022, 4:56 PM.
Tags
None
Referenced Files
F102447173: D33810.diff
Tue, Nov 12, 9:58 AM
Unknown Object (File)
Sun, Nov 10, 4:30 PM
Unknown Object (File)
Sat, Nov 9, 12:15 PM
Unknown Object (File)
Sat, Nov 2, 4:46 AM
Unknown Object (File)
Sat, Nov 2, 4:45 AM
Unknown Object (File)
Sat, Nov 2, 4:44 AM
Unknown Object (File)
Sat, Nov 2, 4:44 AM
Unknown Object (File)
Sat, Nov 2, 4:44 AM
View All 85 Files
Subscribers
imp

Details

Reviewers
alc
kib
Commits
rG4a864f624a70: vm_pageout: Print a more accurate message to the console before an OOM kill
Summary

Previously we'd always print "out of swap space." This can be
misleading, as there are other reasons an OOM kill can be triggered. In
particular, it's entirely possible to trigger an OOM kill on a system
with plenty of free swap space.

MFC after: 2 weeks

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 43815
Build 40703: arc lint + arc unit

Event Timeline

markj created this revision.Jan 10 2022, 4:56 PM
Herald added a subscriber: imp. · View Herald TranscriptJan 10 2022, 4:56 PM
markj requested review of this revision.Jan 10 2022, 4:56 PM
Harbormaster completed remote builds in B43812: Diff 101209.Jan 10 2022, 4:56 PM
markj added a parent revision: D33809: swap_pager: uma_zcreate() doesn't fail.Jan 10 2022, 4:56 PM
markj added a child revision: D33811: vm_pageout: Group sysctl variables together with sysctl definitions.
markj updated this revision to Diff 101211.Jan 10 2022, 5:04 PM

Typo

Harbormaster completed remote builds in B43814: Diff 101211.Jan 10 2022, 5:04 PM
kib accepted this revision.Jan 10 2022, 5:09 PM
kib added inline comments.
sys/vm/vm_pageout.h
84 ↗(On Diff #101211)

Why is this needed?

This revision is now accepted and ready to land.Jan 10 2022, 5:09 PM
markj updated this revision to Diff 101212.Jan 10 2022, 5:13 PM

Drop VM_OOM_MAX, leftover from something else.

This revision now requires review to proceed.Jan 10 2022, 5:13 PM
Harbormaster completed remote builds in B43815: Diff 101212.Jan 10 2022, 5:13 PM
This revision was not accepted when it landed; it landed in state Needs Review.Jan 14 2022, 8:40 PM
Closed by commit rG4a864f624a70: vm_pageout: Print a more accurate message to the console before an OOM kill (authored by markj). · Explain Why
This revision was automatically updated to reflect the committed changes.
markj added a commit: rG4a864f624a70: vm_pageout: Print a more accurate message to the console before an OOM kill.

Revision Contents
Changeset List

PathSize
sys/
vm/
19 lines

Diff 101212

View Options

sys/vm/vm_pageout.c

Loading...