amd64 pmap: preset A and M bits for pmap_qenter() mappings
ClosedPublic
Actions

Authored by kib on Jan 6 2022, 11:09 PM.

Details

Reviewers

alc
markj

Commits

rG15964f1cb393: amd64 pmap: preset A and M bits for pmap_qenter() and pmap_kenter() mappings

Summary

This removes one or two atomic update of the pte on access. Also it
makes the pte constant during its lifecycle.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kib created this revision.Jan 6 2022, 11:09 PM

Herald added a subscriber: imp. · View Herald TranscriptJan 6 2022, 11:09 PM

kib requested review of this revision.Jan 6 2022, 11:09 PM

alc accepted this revision.Jan 6 2022, 11:48 PM

alc added inline comments.

sys/amd64/amd64/pmap.c
3900–3901	Here too?
3912–3913	Here too? P.S. If you decide to update pmap_kenter{,_attr}(), please pick one ordering for the flags and use it consistently.

This revision is now accepted and ready to land.Jan 6 2022, 11:48 PM

Handle kenter. Unify pte bits order in kenter/qenter.

This revision now requires review to proceed.Jan 7 2022, 12:01 AM

alc accepted this revision.Jan 7 2022, 12:05 AM

This revision is now accepted and ready to land.Jan 7 2022, 12:05 AM

markj accepted this revision.Jan 7 2022, 12:13 AM

As an aside, I just verified that arm64 is already setting the equivalent bits.

Closed by commit rG15964f1cb393: amd64 pmap: preset A and M bits for pmap_qenter() and pmap_kenter() mappings (authored by kib). · Explain WhyJan 8 2022, 4:37 AM

This revision was automatically updated to reflect the committed changes.

kib added a commit: rG15964f1cb393: amd64 pmap: preset A and M bits for pmap_qenter() and pmap_kenter() mappings.

Revision Contents
Changeset List

Path

Size

sys/

amd64/

pmap.c

9 lines

Diff 101126

View Options

amd64 pmap: preset A and M bits for pmap_qenter() mappingsClosedPublicActions