Page MenuHomeFreeBSD
Differential D33488

crypto: Move CBC handling into enc_xform_camellia.
ClosedPublic
Actions

Authored by jhb on Dec 15 2021, 9:38 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Sep 28, 6:54 AM
Unknown Object (File)
Fri, Sep 27, 12:40 PM
Unknown Object (File)
Fri, Sep 27, 8:13 AM
Unknown Object (File)
Sun, Sep 22, 2:53 PM
Unknown Object (File)
Thu, Sep 19, 1:13 AM
Unknown Object (File)
Wed, Sep 18, 7:00 PM
Unknown Object (File)
Tue, Sep 17, 1:34 PM
Unknown Object (File)
Tue, Sep 10, 2:27 PM
View All 57 Files
Subscribers
imp
jmg

Details

Reviewers
markj
Commits
rGf84d708b484b: crypto: Move CBC handling into enc_xform_camellia.
Summary

Add an IV to the context that is initialized by the reinit hook.
Encrypt and decrypt operations handle cipher block chaining along with
updating the IV saved in the context.

Sponsored by: The FreeBSD Foundation

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 43427
Build 40315: arc lint + arc unit

Event Timeline

jhb created this revision.Dec 15 2021, 9:38 PM
Herald added subscribers: jmg, imp. · View Herald TranscriptDec 15 2021, 9:38 PM
jhb requested review of this revision.Dec 15 2021, 9:38 PM
jhb added a parent revision: D33487: crypto: Move CBC handling into enc_xform_aes_cbc..
jhb added a child revision: D33489: cryptosoft: Remove CBC handling from swcr_encdec..
Harbormaster completed remote builds in B43397: Diff 100106.Dec 15 2021, 9:38 PM
markj added a comment.Dec 16 2021, 2:41 PM

Do we have any good way to test this cipher? I think the GELI regression tests will exercise it at least, but not cryptocheck AFAIK.

sys/opencrypto/xform_cml.c
70

Need to update ctxsize.

129

Stray newline.

jhb added a comment.Dec 16 2021, 6:57 PM

Hmmm, I should see if OpenSSL supports Camellia.

jhb updated this revision to Diff 100164.Dec 16 2021, 7:54 PM
  • Fix bugs pointed out by Mark.
Harbormaster completed remote builds in B43427: Diff 100164.Dec 16 2021, 7:54 PM
jhb marked 2 inline comments as done.Dec 16 2021, 7:56 PM

cryptocheck didn't catch the ctx size, probably because the extra 16 bytes were stuff on the stack that it didn't hurt to overwrite.

markj accepted this revision.Dec 16 2021, 8:08 PM
This revision is now accepted and ready to land.Dec 16 2021, 8:08 PM
Closed by commit rGf84d708b484b: crypto: Move CBC handling into enc_xform_camellia. (authored by jhb). · Explain WhyDec 16 2021, 10:10 PM
This revision was automatically updated to reflect the committed changes.
jhb added a commit: rGf84d708b484b: crypto: Move CBC handling into enc_xform_camellia..

Revision Contents
Changeset List

PathSize
sys/
opencrypto/
44 lines

Diff 100164

View Options

sys/opencrypto/xform_cml.c

Loading...