crypto: Move CBC handling into enc_xform_camellia.
ClosedPublic
Actions

Authored by jhb on Dec 15 2021, 9:38 PM.

Details

Reviewers

Commits

rGf84d708b484b: crypto: Move CBC handling into enc_xform_camellia.

Summary

Add an IV to the context that is initialized by the reinit hook.
Encrypt and decrypt operations handle cipher block chaining along with
updating the IV saved in the context.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 43397
Build 40285: arc lint + arc unit

Event Timeline

jhb created this revision.Dec 15 2021, 9:38 PM

Herald added subscribers: jmg, imp. · View Herald TranscriptDec 15 2021, 9:38 PM

jhb requested review of this revision.Dec 15 2021, 9:38 PM

jhb added a parent revision: D33487: crypto: Move CBC handling into enc_xform_aes_cbc..

jhb added a child revision: D33489: cryptosoft: Remove CBC handling from swcr_encdec..

Harbormaster completed remote builds in B43397: Diff 100106.Dec 15 2021, 9:38 PM

Do we have any good way to test this cipher? I think the GELI regression tests will exercise it at least, but not cryptocheck AFAIK.

sys/opencrypto/xform_cml.c
70	Need to update ctxsize.
129	Stray newline.

Hmmm, I should see if OpenSSL supports Camellia.

Fix bugs pointed out by Mark.

Harbormaster completed remote builds in B43427: Diff 100164.Dec 16 2021, 7:54 PM

cryptocheck didn't catch the ctx size, probably because the extra 16 bytes were stuff on the stack that it didn't hurt to overwrite.

markj accepted this revision.Dec 16 2021, 8:08 PM

This revision is now accepted and ready to land.Dec 16 2021, 8:08 PM

Closed by commit rGf84d708b484b: crypto: Move CBC handling into enc_xform_camellia. (authored by jhb). · Explain WhyDec 16 2021, 10:10 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rGf84d708b484b: crypto: Move CBC handling into enc_xform_camellia..

Revision Contents
Changeset List

Path

Size

sys/

opencrypto/

xform_cml.c

43 lines

Diff 100106

View Options

sys/opencrypto/xform_cml.c

crypto: Move CBC handling into enc_xform_camellia.ClosedPublicActions