Add accelerated arm64 sha512 to libmd
ClosedPublic
Actions

Authored by andrew on Dec 10 2021, 1:42 PM.

Details

Reviewers

cperciva
cem

Group Reviewers

arm64

Commits

rG4741f854ce12: Add accelerated arm64 sha512 to libmd
rG71bf1c4cc5b2: Add accelerated arm64 sha512 to libmd

Summary

As with sha256 add support for accelerated sha512 support to libmd on
arm64. This depends on clang 13+ to build as this is the first release
with the needed intrinsics. Gcc should also support them, however from
a currently unknown release.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 43279
Build 40167: arc lint + arc unit

Event Timeline

andrew created this revision.Dec 10 2021, 1:42 PM

Herald added subscribers: jmg, imp. · View Herald TranscriptDec 10 2021, 1:42 PM

andrew requested review of this revision.Dec 10 2021, 1:42 PM

Harbormaster completed remote builds in B43279: Diff 99820.Dec 10 2021, 1:42 PM

Lgtm. I didn’t attempt to verify the asm implementation.

lib/libmd/Makefile
140	Is sha3 the right extension for sha2-512? The sha3 feature bit seems unrelated to sha2 and I am unable to find documentation for the march flag.

This revision is now accepted and ready to land.Dec 11 2021, 5:40 PM

andrew added inline comments.Dec 13 2021, 3:30 PM

lib/libmd/Makefile
140	Yes, I checked on both clang and llvm. The compiler developers seem to have grouped sha512 and sha3 together because they were both added in armv8.2.