Per commit view is available at https://kib.kiev.ua/git/gitweb.cgi?p=deviant3.git;a=shortlog;h=refs/heads/ufs
Details
Diff Detail
- Repository
- rG FreeBSD src repository
- Lint
Lint Skipped - Unit
Tests Skipped
Event Timeline
Thanks for working on a separate syscall.
sys/kern/syscalls.master | ||
---|---|---|
3304 | I somewhat think we should add a swapoff2(2) rather than breaking the API. The old one could become a libc wrapper or just be left in place. | |
3307 | I really don't think this expansion space is necessary or worthwhile. If we must do it, please add a len argument like __specialfd. |
sys/kern/syscalls.master | ||
---|---|---|
3304 | I do not like it, the reason for things like accept4(2) was that the applications use the original function by large volume, and changing its prototype is not feasible. For swapoff(2), I do not see a benefit of requiring somebody use swapoff2() vs. adding a zero argument to the swapoff(2) line. If there is any consumer of the syscall besides swapoff(8), at all. | |
3307 | We have flags, which should allow to deterministically control content of *resv1. But ok, I removed this. |
lib/libc/sys/Symbol.map | ||
---|---|---|
263 | I think we need to decide globally what to do about private exports not used by base. Then we should either remove all of them, or keep whatever we collected so far there. |
This patch builds and works. Tested both with the freshly-built swapof(8) and with swapoff from 13.