Page MenuHomeFreeBSD

pfsync: NULL check sc before using it
ClosedPublic

Authored by kp on Dec 3 2021, 9:48 AM.
Tags
None
Referenced Files
F102447162: D33240.diff
Tue, Nov 12, 9:58 AM
Unknown Object (File)
Sat, Nov 2, 6:21 AM
Unknown Object (File)
Sat, Nov 2, 6:21 AM
Unknown Object (File)
Sat, Nov 2, 5:58 AM
Unknown Object (File)
Tue, Oct 29, 10:23 PM
Unknown Object (File)
Sep 29 2024, 8:19 PM
Unknown Object (File)
Sep 20 2024, 9:04 AM
Unknown Object (File)
Sep 19 2024, 12:43 PM

Details

Summary

In pfsync_defer() we must wait to lock sc until we've ensured it's not
NULL.

MFC after: 1 week
Sponsored by: Rubicon Communications, LLC ("Netgate")

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 43115
Build 40003: arc lint + arc unit

Event Timeline

kp requested review of this revision.Dec 3 2021, 9:48 AM

If it go NULL spontaneously, it can go NULL right after this check before PFSYNC_LOCK(). The patch reduces panic chances significantly, of course.

If it go NULL spontaneously, it can go NULL right after this check before PFSYNC_LOCK(). The patch reduces panic chances significantly, of course.

Not so much spontaneously, but it can happen if a user decides to ifconfig pfsync0 destroy.

This revision was not accepted when it landed; it landed in state Needs Review.Dec 6 2021, 12:25 PM
This revision was automatically updated to reflect the committed changes.