Page MenuHomeFreeBSD
Differential D33240

pfsync: NULL check sc before using it
ClosedPublic
Actions

Authored by kp on Dec 3 2021, 9:48 AM.
Tags
None
Referenced Files
F114780090: D33240.diff
Wed, Apr 16, 6:58 PM
Unknown Object (File)
Wed, Apr 16, 12:03 AM
Unknown Object (File)
Mar 8 2025, 5:19 AM
Unknown Object (File)
Mar 3 2025, 9:48 PM
Unknown Object (File)
Feb 24 2025, 9:46 AM
Unknown Object (File)
Feb 23 2025, 11:33 PM
Unknown Object (File)
Feb 21 2025, 9:52 PM
Unknown Object (File)
Feb 17 2025, 8:42 AM
View All 56 Files
Subscribers
farrokhi
glebius
imp
melifaro

Details

Reviewers
None
Group Reviewers
network
pfsense
Commits
rGbbbe18b31795: pfsync: NULL check sc before using it
rG9a663b668c05: pfsync: NULL check sc before using it
rG27bd812c5c92: pfsync: NULL check sc before using it
Summary

In pfsync_defer() we must wait to lock sc until we've ensured it's not
NULL.

MFC after: 1 week
Sponsored by: Rubicon Communications, LLC ("Netgate")

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kp created this revision.Dec 3 2021, 9:48 AM
Herald added subscribers: glebius, melifaro, farrokhi, imp. · View Herald TranscriptDec 3 2021, 9:48 AM
kp requested review of this revision.Dec 3 2021, 9:48 AM
Harbormaster completed remote builds in B43115: Diff 99387.Dec 3 2021, 9:48 AM
kp added a child revision: D33241: pfsync: check IFF_DRV_RUNNING in the correct field.Dec 3 2021, 9:48 AM
glebius added a comment.Dec 3 2021, 4:47 PM

If it go NULL spontaneously, it can go NULL right after this check before PFSYNC_LOCK(). The patch reduces panic chances significantly, of course.

kp added a comment.Dec 3 2021, 4:56 PM
In D33240#751540, @glebius wrote:

If it go NULL spontaneously, it can go NULL right after this check before PFSYNC_LOCK(). The patch reduces panic chances significantly, of course.

Not so much spontaneously, but it can happen if a user decides to ifconfig pfsync0 destroy.

This revision was not accepted when it landed; it landed in state Needs Review.Dec 6 2021, 12:25 PM
Closed by commit rG27bd812c5c92: pfsync: NULL check sc before using it (authored by kp). · Explain Why
This revision was automatically updated to reflect the committed changes.
kp added a commit: rG27bd812c5c92: pfsync: NULL check sc before using it.
kp added a commit: rG9a663b668c05: pfsync: NULL check sc before using it.Dec 13 2021, 1:51 PM
kp added a commit: rGbbbe18b31795: pfsync: NULL check sc before using it.

Revision Contents
Changeset List

PathSize
sys/
netpfil/
pf/
5 lines

Diff 99544

View Options

sys/netpfil/pf/if_pfsync.c

Loading...