Page MenuHomeFreeBSD
Differential D33167

Expand comment explaining reasons for automatic swapoff on shutdown
ClosedPublic
Actions

Authored by kib on Nov 29 2021, 7:13 PM.
Tags
None
Referenced Files
F107460672: D33167.diff
Tue, Jan 14, 11:59 AM
Unknown Object (File)
Sat, Jan 11, 5:53 AM
Unknown Object (File)
Wed, Dec 18, 10:35 AM
Unknown Object (File)
Dec 4 2024, 5:37 PM
Unknown Object (File)
Oct 6 2024, 5:41 AM
Unknown Object (File)
Oct 5 2024, 5:53 PM
Unknown Object (File)
Oct 3 2024, 4:55 AM
Unknown Object (File)
Oct 2 2024, 11:16 PM
View All 49 Files
Subscribers
imp

Details

Reviewers
alc
markj
Commits
rGa5c2d59ed3d6: Expand comment explaining reasons for automatic swapoff on shutdown

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

kib created this revision.Nov 29 2021, 7:13 PM
Herald added a subscriber: imp. · View Herald TranscriptNov 29 2021, 7:13 PM
kib requested review of this revision.Nov 29 2021, 7:13 PM
markj added inline comments.Nov 30 2021, 3:36 PM
sys/kern/vfs_bio.c
1462

I would write "to quiesce the system as much as possible" or something similar. Steady state typically refers to normal operation of the system, and shutdown is abnormal.

1464
1466
kib updated this revision to Diff 99243.Nov 30 2021, 4:26 PM
kib marked 3 inline comments as done.

Mark' notes.

markj accepted this revision.Nov 30 2021, 10:06 PM
This revision is now accepted and ready to land.Nov 30 2021, 10:06 PM
alc accepted this revision.Dec 3 2021, 7:26 AM
Closed by commit rGa5c2d59ed3d6: Expand comment explaining reasons for automatic swapoff on shutdown (authored by kib). · Explain WhyDec 3 2021, 8:50 AM
This revision was automatically updated to reflect the committed changes.
kib added a commit: rGa5c2d59ed3d6: Expand comment explaining reasons for automatic swapoff on shutdown.

Revision Contents
Changeset List

PathSize
sys/
kern/
13 lines

Diff 99173

View Options

sys/kern/vfs_bio.c

Loading...