Add a COMPAT_FREEBSD13 kernel option
ClosedPublic
Actions

Authored by kp on Nov 15 2021, 11:40 PM.

Details

Reviewers

jhb
manu

Group Reviewers

network
pfsense

Commits

rG4e85b6489045: Add a COMPAT_FREEBSD13 kernel option

Summary

Use it wherever COMPAT_FREEBSD11 is currently specified.

Sponsored by: Rubicon Communications, LLC ("Netgate")

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 42814
Build 39702: arc lint + arc unit

Event Timeline

kp created this revision.Nov 15 2021, 11:40 PM

Herald added subscribers: jhibbits, andrew, imp. · View Herald TranscriptNov 15 2021, 11:40 PM

kp requested review of this revision.Nov 15 2021, 11:40 PM

Harbormaster completed remote builds in B42799: Diff 98555.Nov 15 2021, 11:40 PM

kp added a child revision: D33001: pf: add COMPAT_FREEBSD12 for DIOCKEEPCOUNTERS.Nov 15 2021, 11:41 PM

Do we also need to start creating misc/compat13x port?

In D33005#745343, @lwhsu wrote:

Do we also need to start creating misc/compat13x port?

I don't think we need that just yet, at least if I understand the purpose of those ports correctly. The are COMPAT_FREEBSD13 is for D33001

Maybe add this to riscv/conf/GENERIC as well?

Aslo, we do actually need a misc/compat13x port, but not for this change. The recent bump of the shlib version for libdialog.so and libdpv.so at least needs a misc/compat13x port/package. Not sure if we have bumped any other libraries in head. There might be some ncurses changes that might also need to be in misc/compat13x. @bapt would know that better.

This revision is now accepted and ready to land.Nov 16 2021, 5:52 PM

In D33005#745529, @jhb wrote:

Maybe add this to riscv/conf/GENERIC as well?

riscv currently doesn't list any COMPAT_x options, so I'm inclined to not include that here. If we want to turn it on for riscv (and we probably should) I think we should have a separate commit to add COMPAT_FREEBSD12 / COMPAT_FREEBSD13 there. I'l prepare one and post a review soon.