amd64: switch to the physmem KPI
Needs ReviewPublic
Actions

Authored by kevans on Nov 6 2021, 7:28 PM.

Details

Reviewers

kib
markj

Summary

The physmem KPI is already used on arm, arm64, and riscv64; extend it
towards x86. This reduces some complexity in machdep.c in favor of
using platform-common coalescing logic and being a bit easier to grok
at a glance.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 42638
Build 39526: arc lint + arc unit

Event Timeline

kevans created this revision.Nov 6 2021, 7:28 PM

Herald added a subscriber: imp. · View Herald TranscriptNov 6 2021, 7:28 PM

kevans requested review of this revision.Nov 6 2021, 7:28 PM

Harbormaster completed remote builds in B42638: Diff 98142.Nov 6 2021, 7:28 PM

kevans added a parent revision: D32874: kern: physmem: add new KPIs for amd64.Nov 6 2021, 7:28 PM

markj added inline comments.Nov 9 2021, 2:20 PM

sys/amd64/amd64/machdep.c
791	Why __diagused?
859	How can EINVAL arise? Do we really want to stop the test if physmem_exclude_region() fails?

kevans added inline comments.Nov 9 2021, 3:29 PM

sys/amd64/amd64/machdep.c
791	ah, remnants of a former versiin... this used to just assert on the exclude return rather than bail out. Will remove.
859	This one is a brain-o. We do want to stop, but only if we hit an E2BIG (or whatever the "region full" error ends up being), since there's no point in testing once we can't exclude anything else. I think the previous version emitted a notice along those lines, so I'll restore that and fix this.