fexecve(2): allow O_PATH file descriptors opened without O_EXEC
ClosedPublic
Actions

Authored by kib on Nov 3 2021, 1:33 PM.

Details

Reviewers

markj
emaste

Commits

rGbe10c0a91015: fexecve(2): allow O_PATH file descriptors opened without O_EXEC

Summary

This improves compatibility with Linux.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

kib created this revision.Nov 3 2021, 1:33 PM

Herald added a subscriber: imp. · View Herald TranscriptNov 3 2021, 1:33 PM

kib requested review of this revision.Nov 3 2021, 1:33 PM

markj accepted this revision.Nov 3 2021, 2:47 PM

markj added inline comments.

sys/kern/kern_exec.c
543
549	Can this logic live in fgetvp_exec()? Note that that function is unused after this change.

This revision is now accepted and ready to land.Nov 3 2021, 2:47 PM

Move O_PATH check into fgetvp_exec().

This revision now requires review to proceed.Nov 3 2021, 3:17 PM

markj accepted this revision.Nov 3 2021, 3:41 PM

This revision is now accepted and ready to land.Nov 3 2021, 3:41 PM

Closed by commit rGbe10c0a91015: fexecve(2): allow O_PATH file descriptors opened without O_EXEC (authored by kib). · Explain WhyNov 3 2021, 4:03 PM

This revision was automatically updated to reflect the committed changes.

kib added a commit: rGbe10c0a91015: fexecve(2): allow O_PATH file descriptors opened without O_EXEC.

Revision Contents
Changeset List

Path

Size

lib/

libc/

sys/

open.2

3 lines

sys/

kern/

kern_exec.c

27 lines

Diff 97927

View Options

lib/libc/sys/open.2