Page MenuHomeFreeBSD

kernel: Disable errors for -Walloca-larger-than for GCC.
ClosedPublic

Authored by jhb on Sep 13 2021, 6:10 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Oct 26, 5:14 AM
Unknown Object (File)
Fri, Oct 18, 12:36 AM
Unknown Object (File)
Wed, Oct 16, 12:59 PM
Unknown Object (File)
Wed, Oct 16, 11:55 AM
Unknown Object (File)
Wed, Oct 16, 11:54 AM
Unknown Object (File)
Sep 15 2024, 6:53 PM
Unknown Object (File)
Sep 10 2024, 11:06 PM
Unknown Object (File)
Sep 10 2024, 8:28 PM
Subscribers

Details

Summary

GCC complains about the use of alloca() with variable sizes (for XSAVE
state len) in sendsig() for i386. Modern XSAVE state is probably
getting a bit large for the i386 kstack, but downgrade the error to a
warning.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jhb requested review of this revision.Sep 13 2021, 6:10 PM

I opted for alloca() initially because the only alternative there I see is to have one more fpu save area allocated per-thread, realistically. It might be a reasonable way now, esp, if combined with the move of the user fpu save area from kstack.

This revision is now accepted and ready to land.Sep 13 2021, 6:18 PM

Is it maybe worth adding a comment in sendsig along the lines of the above note?