Page MenuHomeFreeBSD

kernel: Disable errors for -Walloca-larger-than for GCC.
ClosedPublic

Authored by jhb on Sep 13 2021, 6:10 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Apr 22, 5:14 PM
Unknown Object (File)
Tue, Apr 22, 7:56 AM
Unknown Object (File)
Mon, Apr 21, 6:17 AM
Unknown Object (File)
Mon, Apr 21, 6:12 AM
Unknown Object (File)
Mon, Apr 21, 6:02 AM
Unknown Object (File)
Mon, Apr 21, 5:37 AM
Unknown Object (File)
Sat, Apr 12, 5:03 AM
Unknown Object (File)
Mon, Apr 7, 1:28 PM
Subscribers

Details

Summary

GCC complains about the use of alloca() with variable sizes (for XSAVE
state len) in sendsig() for i386. Modern XSAVE state is probably
getting a bit large for the i386 kstack, but downgrade the error to a
warning.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jhb requested review of this revision.Sep 13 2021, 6:10 PM

I opted for alloca() initially because the only alternative there I see is to have one more fpu save area allocated per-thread, realistically. It might be a reasonable way now, esp, if combined with the move of the user fpu save area from kstack.

This revision is now accepted and ready to land.Sep 13 2021, 6:18 PM

Is it maybe worth adding a comment in sendsig along the lines of the above note?