Page MenuHomeFreeBSD

swap_pager: Handle large swap_pager_reserve() requests
ClosedPublic

Authored by markj on Sep 7 2021, 3:46 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Oct 22, 3:15 AM
Unknown Object (File)
Mon, Oct 14, 9:50 PM
Unknown Object (File)
Oct 6 2024, 10:39 AM
Unknown Object (File)
Sep 27 2024, 1:31 PM
Unknown Object (File)
Sep 26 2024, 7:04 PM
Unknown Object (File)
Sep 24 2024, 12:30 PM
Unknown Object (File)
Sep 5 2024, 8:07 AM
Unknown Object (File)
Sep 4 2024, 5:15 AM
Subscribers

Details

Summary

This interface is used solely by md(4) when the MD_RESERVE flag is
specified, as in mdconfig -a -t swap -s 1G -o reserve. It
pre-allocates swap blocks for the entire object.

The number of blocks to be reserved is specified as a vm_size_t, but
swp_pager_getswapspace() can allocate at most INT_MAX blocks. vm_size_t
also seems like the incorrect type to use here it refers only to the
size of the VM object, not the size of a mapping. So:

  • change the type of "size" in swap_pager_reserve() to vm_pindex_t, and
  • clamp the requested number of blocks for a single swp_pager_getswapspace() call to INT_MAX.

Reported by: syzkaller

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 41420
Build 38309: arc lint + arc unit