Page MenuHomeFreeBSD

tmpfs: Move partial page invalidation to a separate helper
ClosedPublic

Authored by khng on Aug 25 2021, 8:13 PM.
Tags
None
Referenced Files
F102910188: D31683.diff
Mon, Nov 18, 3:30 PM
Unknown Object (File)
Sun, Oct 27, 7:28 PM
Unknown Object (File)
Sun, Oct 27, 5:26 PM
Unknown Object (File)
Oct 1 2024, 1:40 PM
Unknown Object (File)
Sep 30 2024, 6:33 PM
Unknown Object (File)
Sep 24 2024, 5:15 AM
Unknown Object (File)
Sep 22 2024, 7:50 AM
Unknown Object (File)
Sep 20 2024, 3:05 AM
Subscribers

Details

Summary

The partial page invalidation code is factored out to be a separate
helper from tmpfs_reg_resize().

Sponsored by: The FreeBSD Foundation

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

khng requested review of this revision.Aug 25 2021, 8:13 PM
sys/fs/tmpfs/tmpfs_subr.c
404

Replace the whole 'else' branch with something along the lines:

vm_page_free(m);
m = NULL;
if (!ignerr)
    error = EIO;

and change return (0); at the end with return (error);

1755–1757

By convention 'rv' var holds a Mach error code, not errno. Since tmpfs_partial_page_invalidate() returns errno, better rename rv there.

khng marked 2 inline comments as done.

Cleanups suggested by kib@

This revision is now accepted and ready to land.Aug 25 2021, 8:50 PM