Add arm64 ifunc support in static binaries
ClosedPublic
Actions

Authored by andrew on Aug 23 2021, 9:16 AM.

Details

Reviewers

kib

Group Reviewers

arm64

Commits

rGc30a7ae6384d: Add arm64 ifunc support in static binaries
rGbc5304a00623: Add arm64 ifunc support in static binaries

Summary

Add support for the R_AARCH64_IRELATIVE relocation type in static
binaries on arm64. This is based on the powerpc code, updating it to
use the arm64 resolver ABI, and use the arm64 relocation type.

Tested by: brd

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

andrew created this revision.Aug 23 2021, 9:16 AM

Herald added a subscriber: imp. · View Herald TranscriptAug 23 2021, 9:16 AM

andrew requested review of this revision.Aug 23 2021, 9:16 AM

Harbormaster completed remote builds in B41164: Diff 94039.Aug 23 2021, 9:16 AM

kib added inline comments.Aug 23 2021, 9:44 AM

lib/csu/aarch64/reloc.c
43	What is the point of passing all that zeroes? Don't you want to supply at least AT_HWCAP/AT_HWCAP2 values?

andrew added inline comments.Aug 23 2021, 10:49 AM

lib/csu/aarch64/reloc.c
43	They are reserved for future use so we don't have to change the ABI. We can add it later, currently the SHA256 resolver in libmd calls `elf_aux_info` to read it.