hwpmc: don't validate capabilities in allocation method
ClosedPublic
Actions

Authored by mhorne on Aug 2 2021, 9:09 PM.

Details

Reviewers

emaste
gnn

Group Reviewers

pmc

Commits

rGb475ab8c78ac: hwpmc: don't validate capabilities in allocation method
rG0e78510b7549: hwpmc: don't validate capabilities in allocation method

Summary

These checks were inconsistently applied across the various hwpmc
classes. The condition is already checked by the generic code in
hwpmc_mod.c, so remove them.

Test Plan

Tinderboxed.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

mhorne created this revision.Aug 2 2021, 9:09 PM

Herald added subscribers: andrew, imp. · View Herald TranscriptAug 2 2021, 9:09 PM

mhorne requested review of this revision.Aug 2 2021, 9:09 PM

Harbormaster completed remote builds in B40811: Diff 93140.Aug 2 2021, 9:09 PM

mhorne edited the test plan for this revision. (Show Details)Aug 2 2021, 9:10 PM

Some existing cases returned EPERM for the != caps cases?

In D31388#707800, @emaste wrote:

Some existing cases returned EPERM for the != caps cases?

Yes exactly.

Although, I just noticed the generic allocation code in hwpmc_mod.c checks the capabilities before any of these class-specific checks, so they are more or less useless. I will update this review to just remove them altogether.

The relevant line is here: https://cgit.freebsd.org/src/tree/sys/dev/hwpmc/hwpmc_mod.c#n3935

Switch to just removing the existing redundant capability checks.

Harbormaster completed remote builds in B40999: Diff 93550.Aug 11 2021, 4:42 PM

mhorne retitled this revision from hwpmc: consistently validate capabilities in pcd_allocate_pmc() to hwpmc: don't validate capabilities in allocation method.Aug 11 2021, 4:43 PM

mhorne edited the summary of this revision. (Show Details)

This revision was not accepted when it landed; it landed in state Needs Review.Aug 30 2021, 7:16 PM

Closed by commit rG0e78510b7549: hwpmc: don't validate capabilities in allocation method (authored by mhorne). · Explain Why

This revision was automatically updated to reflect the committed changes.

mhorne added a commit: rG0e78510b7549: hwpmc: don't validate capabilities in allocation method.

Herald added a reviewer: gnn. · View Herald TranscriptAug 30 2021, 7:16 PM

mav added a commit: rGb475ab8c78ac: hwpmc: don't validate capabilities in allocation method.Jul 5 2022, 5:10 PM