Paths

Table of Contentst

Differential D30921

Add infrastructure required for Linux coredump support
ClosedPublic
Actions

Authored by trasz on Jun 28 2021, 10:02 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Oct 23, 6:26 PM

	Unknown Object (File)
	Oct 2 2024, 6:12 PM

	Unknown Object (File)
	Oct 1 2024, 11:33 AM

	Unknown Object (File)
	Sep 30 2024, 9:27 PM

	Unknown Object (File)
	Sep 30 2024, 7:21 PM

	Unknown Object (File)
	Sep 18 2024, 7:24 PM

	Unknown Object (File)
	Sep 18 2024, 6:49 PM

	Unknown Object (File)
	Sep 18 2024, 11:50 AM

View All 59 Files

Subscribers

Details

Reviewers

manu
kib

Commits

rGf707a6cf1a4a: Add infrastructure required for Linux coredump support
rG435754a59ee2: Add infrastructure required for Linux coredump support

Summary

This adds sv_elf_core_osabi, sv_elf_core_abi_vendor,
and sv_elf_core_prepare_notes fields to struct sysentvec,
and modifies imgact_elf.c to make use of them instead of hardcoding
FreeBSD-specific values. It also updates all of the ABI definitions
to preserve current behaviour.

This makes it possible to implement non-native ELF coredump support
without unnecessary code duplication. It will be used for Linux
coredumps.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

trasz created this revision.Jun 28 2021, 10:02 AM

Herald added a reviewer: manu. · View Herald TranscriptJun 28 2021, 10:02 AM

Herald added subscribers: jhibbits, emaste, andrew, imp. · View Herald Transcript

trasz requested review of this revision.Jun 28 2021, 10:02 AM

Harbormaster completed remote builds in B40140: Diff 91431.Jun 28 2021, 10:02 AM

(Tinderboxed.)

Note that this is essentialy a part of https://reviews.freebsd.org/D30019, with Linux-specific bits changed back to FreeBSD-specific ones to preserve old behaviour, and also to make them build.

trasz mentioned this in D30019: linux(4): implement coredump support.Jun 28 2021, 10:06 AM

kib accepted this revision.Jun 28 2021, 11:02 AM

kib added inline comments.

sys/sys/imgact_elf.h
106	I suggest to rename this type, it is too generic for elf-specific usage.

This revision is now accepted and ready to land.Jun 28 2021, 11:02 AM

Closed by commit rG435754a59ee2: Add infrastructure required for Linux coredump support (authored by trasz). · Explain WhyJun 29 2021, 7:58 AM

This revision was automatically updated to reflect the committed changes.

trasz added a commit: rG435754a59ee2: Add infrastructure required for Linux coredump support.

jhb added a commit: rGf707a6cf1a4a: Add infrastructure required for Linux coredump support.May 12 2022, 10:57 PM

Revision Contents
Changeset List

Path

Size

sys/

amd64/

amd64/

6 lines

cloudabi32/

cloudabi32_sysvec.c

3 lines

cloudabi64/

cloudabi64_sysvec.c

3 lines

linux/

3 lines

linux32/

linux32_sysvec.c

3 lines

arm/

arm/

3 lines

cloudabi32/

cloudabi32_sysvec.c

3 lines

arm64/

arm64/

elf32_machdep.c

3 lines

3 lines

cloudabi32/

cloudabi32_sysvec.c

3 lines

cloudabi64/

cloudabi64_sysvec.c

3 lines

linux/

3 lines

compat/

ia32/

3 lines

i386/

i386/

3 lines

linux/

3 lines

kern/

66 lines

mips/

mips/

2 lines

freebsd32_machdep.c

3 lines

powerpc/

powerpc/

elf32_machdep.c

3 lines

elf64_machdep.c

6 lines

riscv/

riscv/

3 lines

sys/

11 lines

5 lines

Diff 91487

sys/amd64/amd64/elf_machdep.c

Loading...

sys/amd64/cloudabi32/cloudabi32_sysvec.c

Loading...

sys/amd64/cloudabi64/cloudabi64_sysvec.c

Loading...

sys/amd64/linux/linux_sysvec.c

Loading...

sys/amd64/linux32/linux32_sysvec.c

Loading...

sys/arm/arm/elf_machdep.c

Loading...

sys/arm/cloudabi32/cloudabi32_sysvec.c

Loading...

sys/arm64/arm64/elf32_machdep.c

Loading...

sys/arm64/arm64/elf_machdep.c

Loading...

sys/arm64/cloudabi32/cloudabi32_sysvec.c

Loading...

sys/arm64/cloudabi64/cloudabi64_sysvec.c

Loading...

sys/arm64/linux/linux_sysvec.c

Loading...

sys/compat/ia32/ia32_sysvec.c

Loading...

sys/i386/i386/elf_machdep.c

Loading...

sys/i386/linux/linux_sysvec.c

Loading...

sys/kern/imgact_elf.c

Loading...

sys/mips/mips/elf_machdep.c

Loading...

sys/mips/mips/freebsd32_machdep.c

Loading...

sys/powerpc/powerpc/elf32_machdep.c

Loading...

sys/powerpc/powerpc/elf64_machdep.c

Loading...

sys/riscv/riscv/elf_machdep.c

Loading...

sys/sys/imgact_elf.h

Loading...

sys/sys/sysent.h

Loading...